Skip to content

Commit

Permalink
Merge pull request #5791 from kodadot/beta
Browse files Browse the repository at this point in the history
  • Loading branch information
yangwao authored Apr 24, 2023
2 parents 901bdd1 + 39b4a8a commit cfaecab
Show file tree
Hide file tree
Showing 253 changed files with 5,547 additions and 3,004 deletions.
14 changes: 9 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
**Thank you for your contribution** to the [KodaDot NFT gallery](https://kodadot.xyz).
**Thank you for your contribution** to the [KodaDot - One Stop Shop for Polkadot NFTs](https://kodadot.xyz).

👇 \_ Let's make a quick check before the contribution.
👇 __ Let's make a quick check before the contribution.

## PR Type

Expand All @@ -11,19 +11,18 @@
## Context

- [ ] Closes #<issue_number>
- [ ] Requires deployment <>
- [ ] Requires deployment <snek/rubick/worker>

#### Before submitting pull request, please make sure:

- [ ] My contribution builds **clean without any errors or warnings**
- [ ] I've merged recent default branch -- **main** and I've no conflicts
- [ ] I've tried to respect high code quality standards
- [ ] I've didn't break any original functionality
- [ ] I've posted a screenshot of demonstrated change in this PR

#### Optional

- [ ] I've tested it at </bsx/collection>
- [ ] I've tested it at </ksm/collection>
- [ ] I've tested PR on mobile
- [ ] I've written unit tests 🧪
- [ ] I've found edge cases
Expand All @@ -39,3 +38,8 @@
## Screenshot 📸

- [ ] My fix has changed **something** on UI; a screenshot is best to understand changes for others.

## Copilot Summary
copilot:summary

copilot:poem
2 changes: 1 addition & 1 deletion .github/diagram.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Empty file added .github/gh
Empty file.
4 changes: 4 additions & 0 deletions .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@
{
"matchUpdateTypes": ["major", "pin"],
"enabled": false
},
{
"packageNames": ["node"],
"enabled": false
}
]
}
9 changes: 3 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Lint, Build & Test workflow
name: Test & Build app

on:
workflow_dispatch:
push:
branches: [main]
pull_request:
branches: [main]
branches: [main, beta, hyper-jpeg]

jobs:
test:
Expand All @@ -20,10 +20,7 @@ jobs:
run: pnpm test

build:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ jobs:
with:
name: generated-dist

- run: ls -l

- name: Install Dependencies
uses: ./.github/actions/pnpm-install

Expand Down
6 changes: 3 additions & 3 deletions ACTIVITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ flowchart TD

[Peak on recent activity over KodaDot](https://repo-tracker.com/r/gh/kodadot/nft-gallery)

![image](https://user-images.githubusercontent.com/5887929/225908767-f550b6f9-8456-451e-a669-702e2554ae0e.png)
![image](https://user-images.githubusercontent.com/5887929/232563230-85fcda10-2cd8-46a2-b4aa-a0f1261a0660.png)

![image](https://user-images.githubusercontent.com/5887929/225908704-4095abae-cf01-473b-8458-59a19dab272a.png)
![image](https://user-images.githubusercontent.com/5887929/232563299-39e84aa1-19c8-4031-9488-6813f74f65f3.png)

## We're constantly growing!

Expand Down Expand Up @@ -93,6 +93,6 @@ Check out KodaDot's [monthly statistics](https://github.com/kodadot/nft-gallery/
### New Issues and pull requests
- https://www.repotrends.com/kodadot/nft-gallery

![image](https://user-images.githubusercontent.com/5887929/225909152-395aaaf8-dbc4-4210-9cce-a4ad6066e87b.png)
![image](https://user-images.githubusercontent.com/5887929/232562963-f7f42c34-89ea-4783-8dad-a426dd91c262.png)


2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ Since we're using [Cypress](https://www.cypress.io/) as our primary E2E tool for

One of the main reasons tests will fail (except when bugs get introduced) is that we're using custom HTML tags to [select elements](https://docs.cypress.io/guides/references/best-practices#Selecting-Elements) within the testing suite. If your contribution touches components with these custom tags and you get failed tests, these selectors must be checked and usually adjusted.

You can identify these kinds of problems by seeing similar-looking test reports:
You can identify these kinds of problems by seeing similar-looking test reports:
`Expected to find element: [data-cy="submit"], but never found it.`

TL;DR: If you're touching components which include HTML tags such as `data-cy="submit"`, and the tests fail, make sure the tests still use the correct selector.
Expand Down
86 changes: 86 additions & 0 deletions QA.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
# Hiring Quality Assurance Specialist for KodaDot NFT Gallery

## About

KodaDot, an NFT gallery that aims to be builder-owned and the ultimate public good, is always on the lookout for the best talent to join our growing team. We have a variety of opportunities available, including full-time, part-time, internships, freelance, and temporary gigs.

## Responsibilities

- Ensure the quality and reliability of the KodaDot NFT gallery through thorough testing
- Work closely with the development team to identify, report, and resolve issues in a timely manner
- Collaborate with the community, both in discussion and implementation of new features
- Participate in code reviews, maintaining high code quality standards
- Use various testing methodologies and tools to validate the functionality and performance of the product
- Offload 30% of dev work by checking if specific PRs work as intended, reporting and raising bugs that break UX, identifying missing functionality that was accidentally removed
- Write and update E2E and unit tests (using Vite)
- Communicate with the team in issues to help offload major context switching from devs
- Tech-savvy QA is preferred
- Give "works-for-me" labels on PRs if things work as intended

## Requirements

- Strong proficiency in Node.js and adherence to its supported versions
- Experience with pnpm as a package manager
- Knowledge of Vue.js and familiarity with Vue Language Features (Volar) and Vue VSCode Snippets
- Understanding of KodaDot's tech stack and infrastructure
- Strong communication skills for effective collaboration with the community and team
- Familiarity with KodaDot's coding conventions and recommendations

## Quality Assurance

To have a faster pace of development, as our current pace of pull-requests was hitting 250 pull-requests in February on a monthly average, we've realized we need more people to participate and to share more humble and honest feedback with developers on their work.

The result would be that we could deliver user experience quality in a shorter time window. It's pretty natural that developers sometimes miss delivering the 100% specification in an issue or something breaks. It happens, and no need to make drama out of it. Everyone is learning.

Until we have e2e tests complete on KodaDot, we would like to happily reward your participation for your input on our pull-requests to the codebase.

To participate, you must respect our code of conduct below.

## Code of Conduct

- Demonstrating empathy and kindness toward other people
- Being respectful of differing opinions, viewpoints, and experiences
- Giving and gracefully accepting constructive feedback
- Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
- Focusing on what is best not just for us as individuals, but for the overall community
- You can read more about our [CODE_OF_CONDUCT](https://github.com/kodadot/nft-gallery/blob/main/CODE_OF_CONDUCT.md)

## Rewards

Once we are satisfied with your approach, we can give you rewards for reviewing our pull-requests.

This is still undergoing the thought process and experiment to establish a fixed amount of rewards for participation.

The base range where we value your contribution is around $20-$50. If there is an opportunity for you to be a technical contributor and make origin pull-request suggestions (what and why should be done another way), the possibility raises up to $100.

## Opportunities at KodaDot

- Full-time Quality Assurance Specialist
- Part-time Quality Assurance Specialist
- Quality Assurance Internship

## Qualification for full-time, part-time & paid internships

To be considered for these positions, candidates should have:

- A strong track record on their GitHub profile, showcasing open-source contributions
- Excellent cooperation and coordination skills within a team
- Prior experience in quality assurance, testing methodologies, and tools
- A fast learning curve and the ability to adapt to change requests quickly
- A history of collaborating with development teams to improve product quality

## How to apply?

KodaDot offers paid interviews, valuing your time and contributions. You will be paid for completed pull requests (10-20) that are successfully merged. To start, focus on tackling issues with p1 or p2 labels, as they are often challenging and showcase your abilities.

## Next stage

After completing 10-20 merged pull requests, you may be eligible to join our core team. Contact yangwao on Discord to discuss the next steps and potential long-term tasks.

Our hiring process prioritizes cultural fit and teamwork. We are interested in character traits, problem-solving abilities, and your willingness to help others with their PRs. This approach ensures a strong, long-term team dynamic as our codebase grows in complexity.

## Payroll

Upon joining our team, KodaDot offers competitive pay based on your location, skill set, experience, code quality, and availability. Annual compensation ranges between $40,000 to $160,000.

Are you ready to shape the future of the NFT space with KodaDot? Choose your path, and together, let's make an impact in the NFT gallery world!
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# One Stop Shop for your Polkadot NFTs
# One Stop Shop for your Polkadot NFTs

![](https://github.com/kodadot/kodadot-presskit/blob/main/v3/KODA_v3.png?raw=true)

# Contributing
[![Lint, Build & Test workflow](https://github.com/kodadot/nft-gallery/actions/workflows/build.yml/badge.svg)](https://github.com/kodadot/nft-gallery/actions/workflows/build.yml) [![cypress](https://github.com/kodadot/nft-gallery/actions/workflows/e2e.yml/badge.svg)](https://github.com/kodadot/nft-gallery/actions/workflows/e2e.yml) [![Reviewdog](https://github.com/kodadot/nft-gallery/actions/workflows/reviewdog.yml/badge.svg)](https://github.com/kodadot/nft-gallery/actions/workflows/reviewdog.yml)
[![Test & Build app](https://github.com/kodadot/nft-gallery/actions/workflows/build.yml/badge.svg)](https://github.com/kodadot/nft-gallery/actions/workflows/build.yml) [![cypress](https://github.com/kodadot/nft-gallery/actions/workflows/e2e.yml/badge.svg)](https://github.com/kodadot/nft-gallery/actions/workflows/e2e.yml) [![Reviewdog](https://github.com/kodadot/nft-gallery/actions/workflows/reviewdog.yml/badge.svg)](https://github.com/kodadot/nft-gallery/actions/workflows/reviewdog.yml) [![Maintainability](https://api.codeclimate.com/v1/badges/7d14fab327c632d5f0ce/maintainability)](https://codeclimate.com/github/kodadot/nft-gallery/maintainability)

![image](https://user-images.githubusercontent.com/5887929/217076362-464e1293-8a2d-43ee-829f-fba17408e4c3.png)

Expand Down
10 changes: 5 additions & 5 deletions components/CookieBanner.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@
</template>

<script lang="ts" setup>
import { useState } from 'vue-gtag-next'
// import { useState } from 'vue-gtag-next'
const { isEnabled } = useState()
// const { isEnabled } = useState()
const hasDisplayedCookieBanner = ref(
localStorage.getItem('cookies_enabled') !== null || false
)
const acceptCookies = () => {
if (isEnabled) {
isEnabled.value = true
}
// if (isEnabled) {
// isEnabled.value = true
// }
localStorage.setItem('cookies_enabled', '1')
hasDisplayedCookieBanner.value = true
}
Expand Down
7 changes: 6 additions & 1 deletion components/Navbar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
fixed-top
mobile-burger
spaced
wrapper-class="container is-fluid">
:wrapper-class="{ container: true, 'is-fluid': !isMobile }">
<template #brand>
<b-navbar-item :to="{ path: '/' }" class="logo" tag="nuxt-link">
<img
Expand Down Expand Up @@ -77,6 +77,10 @@
id="NavChainSelect"
class="navbar-chain custom-navbar-item"
data-cy="chain-select" />
<NotificationBoxButton
v-if="account"
:show-label="isMobile"
@closeBurgerMenu="closeBurgerMenu" />
<template v-if="isMobile">
<MobileLanguageOption v-if="!account" />
<MobileExpandableSection
Expand Down Expand Up @@ -150,6 +154,7 @@ import ChainSelectDropdown from '~/components/navbar/ChainSelectDropdown.vue'
import StatsDropdown from '~/components/navbar/StatsDropdown.vue'
import MobileNavbarProfile from '~/components/navbar/MobileNavbarProfile.vue'
import ConnectWalletButton from '~/components/shared/ConnectWalletButton.vue'
import NotificationBoxButton from '~/components/navbar/NotificationBoxButton.vue'
import { ConnectWalletModalConfig } from '@/components/common/ConnectWallet/useConnectWallet'
import { BModalConfig } from 'buefy/types/components'
import type Vue from 'vue'
Expand Down
Loading

0 comments on commit cfaecab

Please sign in to comment.