Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update i18n translate plugin to use Transifex #2

Closed
yangwao opened this issue Jan 29, 2021 · 8 comments
Closed

update i18n translate plugin to use Transifex #2

yangwao opened this issue Jan 29, 2021 · 8 comments
Assignees
Labels
$$ ~51-150usd A-nuxt good first issue as new commer, something you could start with p4 affecting less than 10% of app

Comments

@yangwao
Copy link
Member

yangwao commented Jan 29, 2021

Use proper translation management system, so anyone can contribute through transifex or similar systems

@yangwao yangwao mentioned this issue Feb 10, 2021
3 tasks
@yangwao yangwao changed the title i18n translate plugin update i18n translate plugin to use Transifex Feb 18, 2021
@yangwao yangwao mentioned this issue Mar 4, 2021
@yangwao yangwao added the good first issue as new commer, something you could start with label Mar 7, 2021
@yangwao yangwao added the $$ ~51-150usd label Mar 24, 2021
@roiLeo
Copy link
Contributor

roiLeo commented Sep 9, 2021

This one is easy to set up.

You have to :

  1. Create a Transifex account
  2. Join or recreate "Kodadot" organisation
  3. Follow these steps to link github project
  4. Edit the Yaml config. Mine is:
filters:
  - filter_type: file
    # all supported i18n types: https://docs.transifex.com/formats
    file_format: KEYVALUEJSON
    source_language: en
    source_file: src/locales/en.json
    # path expression to translation files, must contain <lang> placeholder
    translation_files_expression: 'src/locales/<lang>.json'
  1. Profit.

Some of the locales should be renamed to match the right language.
Here you can find an automatic pull request example to see what it looks like.

@yangwao yangwao added A-nuxt p3 non-core, affecting less than 40% labels Dec 13, 2021
@yangwao
Copy link
Member Author

yangwao commented Dec 13, 2021

This one is easy to set up.

Nice!

Here you can find an automatic pull request example to see what it looks like.

But who will receive contribution credit for translation, transifex bot? If I'm right transifex it bridges through their bot to make it simple, which is doable, but we are quite loosing credits for person who contributed, hmm

@roiLeo
Copy link
Contributor

roiLeo commented Dec 14, 2021

But who will receive contribution credit for translation, transifex bot? If I'm right transifex it bridges through their bot to make it simple, which is doable, but we are quite loosing credits for person who contributed, hmm

Yes Transifex bot will do pull request.
Transifex user base don't have to link their github account to participate in some projects, you will always be able to see who has contributed the most to their platform but not here and I understand your concerns.

The good thing is that we can set up an approbation workflow where when we reach more than 80% of translated text it will create an automatic pull request .

yangwao pushed a commit that referenced this issue Mar 27, 2022
@vikiival vikiival mentioned this issue Mar 28, 2022
17 tasks
@yangwao yangwao added p5 ideas for future and removed p3 non-core, affecting less than 40% labels Apr 8, 2022
@roiLeo roiLeo self-assigned this May 12, 2022
@roiLeo
Copy link
Contributor

roiLeo commented Aug 12, 2022

🧪 Testing Crowdin integration in roiLeo#21

@yangwao yangwao added p4 affecting less than 10% of app and removed p5 ideas for future labels Aug 23, 2022
yangwao added a commit that referenced this issue Aug 28, 2022
Captain planet sends supplemental release #2
vikiival pushed a commit that referenced this issue Sep 23, 2022
daiagi added a commit to daiagi/nft-gallery that referenced this issue Mar 5, 2023
vikiival pushed a commit that referenced this issue Jul 21, 2023
* massmint pages

* bsx/assets

* bsx/claim

* bsx/incomingOffers

* bsx/offers

* bsx/stats

* bsx/waifu

* rmrk/mint
@jozanek
Copy link

jozanek commented Jan 22, 2024

Hey, is this issue still valid? I am looking for some first issue and this one is oldest so wanted to have a look at it.

@roiLeo
Copy link
Contributor

roiLeo commented Jan 22, 2024

Hey, is this issue still valid? I am looking for some first issue and this one is oldest so wanted to have a look at it.

already completed, you might want to check out any P3 or "good first" issue

@vikiival
Copy link
Member

Let's close then

@vikiival vikiival closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd A-nuxt good first issue as new commer, something you could start with p4 affecting less than 10% of app
Projects
None yet
Development

No branches or pull requests

4 participants