Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composition API as required contributon practice #4128

Closed
3 tasks
vikiival opened this issue Oct 17, 2022 · 4 comments · Fixed by #4130
Closed
3 tasks

Add composition API as required contributon practice #4128

vikiival opened this issue Oct 17, 2022 · 4 comments · Fixed by #4130
Assignees
@kkukelka
Labels
$ ~<50usd A-docs should be related with docs or hello enhancement New feature or request good first issue as new commer, something you could start with hacktoberfest p2 core functionality, or is affecting 60% of app

Comments

@vikiival
Copy link
Member

vikiival commented Oct 17, 2022 •
edited
Loading

Is your feature request related to a problem?

Some notes to help us migrate to vue3/nuxt3:
We need to reduce using nuxt-property-decorator first and use composition API instead.
It will help us to migrate to vue3/nuxt3
nuxt-community/nuxt-property-decorator#83 (comment). at least for newer components
related: #2893

Originally posted by @preschian in #2690 (comment)

The task
@vikiival vikiival added enhancement New feature or request A-docs should be related with docs or hello labels Oct 17, 2022
@vikiival vikiival assigned vikiival and unassigned vikiival Oct 17, 2022
@vikiival vikiival added hacktoberfest good first issue as new commer, something you could start with $ ~<50usd p2 core functionality, or is affecting 60% of app labels Oct 17, 2022
@roiLeo
Copy link
Contributor

roiLeo commented Oct 17, 2022

link it with #3789

@kkukelka
Copy link
Member

👋

@kodabot
Copy link
Collaborator

kodabot commented Oct 17, 2022

ASSIGNED - @kkukelka 🔒 LOCKED -> Wednesday, October 19th 2022, 18:54:52 UTC -> 54 hours

@kkukelka
Copy link
Member

kkukelka commented Oct 17, 2022 •
edited
Loading

@vikiival the style guide you posted is only partially applicable to our codebase, as its examples use the Options API
-> I'll link to this one https://vuejs.org/guide/introduction.html

@kkukelka kkukelka mentioned this issue Oct 17, 2022
Merged
19 tasks
@yangwao yangwao changed the title Add composition API as required contributon pactise Add composition API as required contributon practice Oct 18, 2022
@roiLeo roiLeo mentioned this issue Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkukelka kkukelka

Labels
$ ~<50usd A-docs should be related with docs or hello enhancement New feature or request good first issue as new commer, something you could start with hacktoberfest p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update styleguide with info about composition api kkukelka/nft-gallery
4 participants
@roiLeo @kkukelka @vikiival @kodabot