Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update styleguide with info about composition api #4130

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

kkukelka
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring
  • Chore

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kkukelka kkukelka requested review from a team as code owners October 17, 2022 17:51
@kkukelka kkukelka requested review from prachi00 and petersopko and removed request for a team October 17, 2022 17:51
@kodabot
Copy link
Collaborator

kodabot commented Oct 17, 2022

SUCCESS @kkukelka PR for issue #4128 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 06d79d9
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/634ee205ab0b6600082b3b2d
😎 Deploy Preview https://deploy-preview-4130--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prachi00 prachi00 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 17, 2022
STYLE_GUIDE.md Outdated Show resolved Hide resolved
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would pefsonally remove the class syntax in general

@codeclimate
Copy link

codeclimate bot commented Oct 18, 2022

Code Climate has analyzed commit 06d79d9 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 37.54 USD/KSM ~ 1.332 $KSM
🧗 EqdyzrzVmeHwMdMwvPeCMnNdbuQDbD3YrjY93xq9Ln3jUGW
🔗 0x361943848fea52f6510fb2bcc9b861993b557db946c2a96aaf1153fe1630b33f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 19, 2022
@vikiival vikiival merged commit 073214f into kodadot:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add composition API as required contributon practice
5 participants