Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stacking / grouping items from same collection in explorer / bundles / spammy collection #5385

Closed
yangwao opened this issue Mar 26, 2023 · 20 comments · Fixed by #7269 or #7641
Closed

Stacking / grouping items from same collection in explorer / bundles / spammy collection #5385

yangwao opened this issue Mar 26, 2023 · 20 comments · Fixed by #7269 or #7641
Assignees
@daiagi
Labels
$ ~<50usd A-explorer A-nuxt A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama A-statemint-ahp Polkadot Asset Hub related issues anti-spam p1 preventing everyone from using app UX first Improvement for UX

Comments

@yangwao
Copy link
Member

yangwao commented Mar 26, 2023 •
edited by exezbcz
Loading

In explorer when we are showing items, it's pretty useless for user to see many same items from one collection and it acts as visual spam. "antispam card"

I propose these filters in particular order

  • using same IPFS hash - that classify definitely will be same visual item
  • same price - indicates from one serial mint - if someone sets same price from minting, whatever.
  • only one transfer (can still be some kind of airdrop from whitelist/allowlist)
  • any other filters?

📟 @vikiival I guess we would need resolver for this kind of inspection on explorer to get reply faster from squid?

Design

Basics

  • since we don't have a listings tab, this card will be only visible in explore/items
  • card will show the name of the duplicate nft - when nft would be the same (img, description...) except name (Name #.23 and name #.45) is it possible to use this card as well - but without the number at the end?
  • how many times the nft is duplicated
  • floor price of all the same nfts
  • collection name, the imgs are from
  • visit button
  • there is also small card:
    • used only on smaller previews
    • absence of floor price, otherwise working similarly

Functionality

  • the nft card will work the same as other nft card
  • stroke to the most contrast color in the mode + opacity overlay
  • if you click the nft img, it will redirect you to the collection
  • same with collection name and view
  • basically it's a shortcut to collection

I would propose start doing this globally or at least on rmrk and rmrk2 as there is massive amount of spam items and we want to highlight good collections

image

can test with
https://beta.kodadot.xyz/rmrk2/u/DkjzQrt7U5WN66STqXmXeQYZkcd2mZuUqzncjXwDCck2wUQ?tab=collection

Lmk if you have any questions 🚀
@yangwao yangwao changed the title Stacking items from same collection in explorer Stacking / grouping items from same collection in explorer Mar 26, 2023
@yangwao yangwao added the p3 non-core, affecting less than 40% label Mar 26, 2023
@vikiival
Copy link
Member

Yes please open issue in kodadot/loligo as this needs to be implemented across indexers

@vikiival vikiival mentioned this issue Mar 14, 2024
Open
@vikiival
Copy link
Member

kodadot/stick#248

@yangwao
Copy link
Member Author

yangwao commented Mar 31, 2023

Can be tested with this one for example

@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Mar 31, 2023
@vikiival vikiival mentioned this issue Apr 1, 2023
Open
@yangwao
Copy link
Member Author

yangwao commented Apr 11, 2023

🥹

image

@yangwao yangwao added A-basilisk issues related to basilisk parachain p3 non-core, affecting less than 40% UX first Improvement for UX visual change not affecting ux of app koda2 A-profile related to profile section koda3 navigation trending A-multi-chain interoperability issues across more parachains A-moonriver issues related to MoonRiver network A-moonbeam issues related to Moonbeam network redesign and removed p2 core functionality, or is affecting 60% of app labels Apr 11, 2023
@kodabot
Copy link
Collaborator

kodabot commented Jul 4, 2023

ASSIGNMENT EXPIRED - @daiagi has been unassigned.

@daiagi
Copy link
Contributor

daiagi commented Jul 7, 2023

@JustLuuuu JustLuuuu mentioned this issue Aug 3, 2023
Closed
@yangwao yangwao changed the title Stacking / grouping items from same collection in explorer Stacking / grouping items from same collection in explorer / bundles / spammy collection Sep 10, 2023
@yangwao
Copy link
Member Author

yangwao commented Sep 10, 2023

Grouping by same IPFS link pls?

image

@yangwao yangwao added p1 preventing everyone from using app A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama A-statemint-ahp Polkadot Asset Hub related issues and removed p2 core functionality, or is affecting 60% of app labels Sep 10, 2023
@daiagi daiagi self-assigned this Sep 11, 2023
@kodabot
Copy link
Collaborator

kodabot commented Sep 11, 2023

ALREADY UNASSIGNED - @daiagi, you cannot be assigned twice!

@daiagi
Copy link
Contributor

daiagi commented Sep 12, 2023

@exezbcz what about "buy now" / "list now" on stacked cards?
my guess is these buttons shouldn't be on stacked card since it isn't representing a single item

wdyt?

@vikiival
Copy link
Member

what about "buy now" / "list now" on stacked cards?

I would personally take the cheapest from the stack.

@exezbcz
Copy link
Member

exezbcz commented Sep 12, 2023

my guess is these buttons shouldn't be on stacked card since it isn't representing a single item

its representing multiple "same items"

  • its showing the floor price as well.

I would keep all the button same as with normal item

  • when clicking cart - It will add the cheapest one in the stack - I think this could be added in V2, I will also create a visual indicator for the stacked card
  • when clicking buy now - open modal with cheapest item

with listing, I would enable this as well.
On profile, its showing items you own, imagine you have like 300 of them (no matter whether you are the owner or creator + owner), you want to list them.

  • When clicking this stacked img, that represents all the items you own and are the same, all the item that don't have price will be added into mass list popup.
  • then the flow is the same

wdyt?

This was referenced Sep 14, 2023
Merged
Merged
@yangwao
Copy link
Member Author

yangwao commented Oct 3, 2023 •
edited
Loading

reopen if this got merged?

related

@yangwao yangwao added the A-nuxt label Oct 5, 2023
@yangwao yangwao reopened this Oct 5, 2023
@daiagi
Copy link
Contributor

daiagi commented Oct 5, 2023 •
edited
Loading

Yep. I'm working on reimplennting it on the indexer side, so we can have sensible query

@exezbcz exezbcz mentioned this issue Oct 5, 2023
Closed
@daiagi
Copy link
Contributor

daiagi commented Oct 11, 2023

PR coming soon

@vikiival
Copy link
Member

Screenshot 2023-10-12 at 15 16 43

@daiagi
Copy link
Contributor

daiagi commented Oct 12, 2023

Thanks @vikiival

Fe pr is about a day away
After that next steps will be to implement indexer side on kusama

@daiagi daiagi mentioned this issue Oct 13, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daiagi daiagi

Labels
$ ~<50usd A-explorer A-nuxt A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama A-statemint-ahp Polkadot Asset Hub related issues anti-spam p1 preventing everyone from using app UX first Improvement for UX
Projects
Asset Hub Implementation - Components
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/stack-cards kodadot/nft-gallery
Revive-stacked-cards kodadot/nft-gallery
5 participants
@yangwao @vikiival @daiagi @exezbcz @kodabot