Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ TokenEnitity on RMRK #274

Merged
merged 5 commits into from
Sep 25, 2023
Merged

✨ TokenEnitity on RMRK #274

merged 5 commits into from
Sep 25, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Sep 19, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

@vikiival

@daiagi daiagi mentioned this pull request Sep 19, 2023
Open
roiLeo
roiLeo reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it run?

src/mappings/v2/mint.ts Outdated Show resolved Hide resolved
@roiLeo roiLeo mentioned this pull request Sep 21, 2023
Open
@daiagi
Copy link
Contributor Author

daiagi commented Sep 21, 2023

does it run?

wdym?

I tested it on local node and it works

@daiagi @roiLeo
Update src/mappings/v2/mint.ts
ff32332 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@roiLeo
Copy link
Contributor

roiLeo commented Sep 21, 2023

I tested it on local node and it works

could you share (if possible) a screenshot of a query result on tokenEntity?

@daiagi
Copy link
Contributor Author

daiagi commented Sep 21, 2023

I tested it on local node and it works

could you share (if possible) a screenshot of a query result on tokenEntity?

Sure

image

vikiival
vikiival requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the five sec delay makes it slow, please clarify ^-^

src/mappings/shared/handleTokenEntity.ts Outdated Show resolved Hide resolved
src/mappings/v1/mint.ts Outdated Show resolved Hide resolved
@vikiival vikiival merged commit bb416a9 into kodadot:main Sep 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daiagi @roiLeo @vikiival