Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BalanceInput tests fails #6866

Closed
roiLeo opened this issue Aug 22, 2023 · 5 comments · Fixed by #6874
Closed

BalanceInput tests fails #6866

roiLeo opened this issue Aug 22, 2023 · 5 comments · Fixed by #6874
Assignees
Labels
$ ~<50usd A-tests bug Something isn't working p2 core functionality, or is affecting 60% of app

Comments

@roiLeo
Copy link
Contributor

roiLeo commented Aug 22, 2023

@roiLeo roiLeo added bug Something isn't working p2 core functionality, or is affecting 60% of app A-tests labels Aug 22, 2023
@yangwao yangwao added the $ ~<50usd label Aug 22, 2023
@yangwao
Copy link
Member

yangwao commented Aug 22, 2023

@stephenjason89 can you check as it seems you broke tests in #6836 😄

@stephenjason89
Copy link
Contributor

Thanks @yangwao I will check it now

@stephenjason89
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 22, 2023

ASSIGNED - @stephenjason89 🔒 LOCKED -> Wednesday, August 23rd 2023, 21:45:39 UTC -> 36 hours

@stephenjason89
Copy link
Contributor

stephenjason89 commented Aug 22, 2023

@yangwao upon checking, everything is working even for the failing test.
I believe there's a problem with the test.

Is the current testing setup working for script setup?
I believe it is not working with composition api script setup

There are only 2 components on unit testing 😆
image

I don't have a reference for a working sample, I've been debugging this for quite a while but i believe '@vue/test-utils' doesn't support script setup

they do in '@vue/test-utils@next' but that needs vue 3

Would you want me to remove the failing test for the meantime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-tests bug Something isn't working p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants