Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➖ unused PaginatedCardList #6859

Merged
merged 2 commits into from
Aug 22, 2023
Merged

➖ unused PaginatedCardList #6859

merged 2 commits into from
Aug 22, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 21, 2023

@roiLeo roiLeo requested a review from a team as a code owner August 21, 2023 15:17
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team August 21, 2023 15:17
@netlify
Copy link

netlify bot commented Aug 21, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b16b897
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e459e73ccf380008a106f3
😎 Deploy Preview https://deploy-preview-6859--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 21, 2023

AI-Generated Summary: This pull request removes the unused PaginatedCardList.vue component from the 'rmrk' gallery. The component facilitated pagination and certain search functionalities for the gallery items. With the deletion of this component, all functionality and attributes related to gallery item pagination and searching will be affected. The removal includes dependencies and methods such as DocumentNode query, InfiniteScrollMixin, NFTWithMeta items, and functions for loading and resetting pages.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Aug 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

y u no build?

image

@codeclimate
Copy link

codeclimate bot commented Aug 22, 2023

Code Climate has analyzed commit b16b897 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 22, 2023

y u no build?

#6866

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 22, 2023
@yangwao yangwao merged commit 3ddb744 into kodadot:main Aug 22, 2023
10 of 11 checks passed
@roiLeo roiLeo deleted the chore/remove/PaginatedCardList branch August 22, 2023 11:58
This was referenced Aug 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roiLeo @yangwao @Jarsen136