-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are auto-teleported funds preferred over funds on ahp? #9962
Comments
after this suggestion #9596 (comment) was made we increased the ED #9746 (comment) that's why the auto-teleport got triggered but I guess @dudo50 was suggesting to only increase the polkadot one to 1.5 DOT and leave the ahp like it was at 0.1 DOT if the user could. see 1.1 DOT on ahp our ED of 1.5 DOT wouldn't make any sense. |
@hassnian , I would increase Asset hub too just in case. Not by 1dot but having at least 0.5 dot on Asset hub would be safe. Better safe than sorry for now. With kind regards, |
@hassnian if you get approval from the rest of the team - You could also bring Kusama back given, that you also increase ED on both Kusama and AssetHubKusama by at least 0.2 KSM. Then users should be safe. |
By the way @hassnian how was the user able to transfer through autoteleport after the increase to 1.5 ED? They dusted their account via the transfer meaning they probably had 1.7-2.8Dot in their Relay chain account. They should only have been able to teleport 0.1-1.3DOT based on their balance (0.1 if they had 1.7DOT or 1.3DOT if they had 2.8DOT). The point I am trying to make here is, that the users should not only be warned about potential asset loss. They need to be prevented from sending until they deposit some more to their account if the transfer would leave them below increased ED. |
I've checked format of the messages that are being formatted by our SDK and they are correct. The issue is in the ED setting. (You should not allow users to send at all if they will go below increased ED so do not display them warning message that they can click and ignore and send call anyways because that will for sure lead to loss instead prevent them to do the call). Work with their ballance in following way. Display them they have teleportable balance on Relay (This is an example) of 0.3 dot if they have 1.8dot on Relay. Only allow them to teleport 0.3 DOT-XCMFEE then. |
Also in conversation with @vikiival we found out, that there should be 2 sets of ED. One for users that are not doing XCM in their call and other one for users that are trying to use XCM. Because if user has enough assets on AH to mint in drop why giving them increased ED when they are not using XCM? They will not loose assets if they use regular calls. Only give them increased set of ED if they are doing XCM aka Teleport call to prevent them from loosing assets @hassnian . |
@JustLuuuu check #9966 |
@dudo50 can you dm on TG , my id @hscexe |
ASSIGNED - @hassnian 🔒 LOCKED -> Thursday, April 4th 2024, 22:05:46 UTC -> 36 hours |
One of the people who lost funds in auto teleport was this guy. Sadly, he lost his funds twice. After losing his funds the first time, there was 1.1DOT added to his account, but this time on AHP directly. So he had something newly added on Polkadot relay chain, but he also had 1.1 DOT on ahp. He wanted to mint 1 NFT (Drops: Shapes). He was asked to use auto teleport, and that's when he lost his funds from the relay chain a second time.
Extrinsic: https://polkadot.subscan.io/extrinsic/20164870-3
Address: 14dHRg2P8NQfg68MktZjYeWbgvXEUH4KsvXEoxByeryMXPWB
Amount: 1.6
Twitter: https://twitter.com/rickybobby440
My question is, existential minimum on ahp is 0.1, how is it possible that autoteleport was activated even though he had enough funds in his wallet on ahp? (1.1DOT)
The text was updated successfully, but these errors were encountered: