Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:wrech: trigger of XCM autoteleport on ill-logical cases #9966

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Apr 3, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

I have a "poor" account (sub 1 DOT)
and basically everytime I am trying to do a drop I will have an autoteleport that is asking me to get all my balance from Polkadot to AssetHub.

This fix basically decreases ED so cases like that are not triggered

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@vikiival vikiival requested a review from a team as a code owner April 3, 2024 09:43
@vikiival vikiival requested review from daiagi and hassnian and removed request for a team April 3, 2024 09:43
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f8463d1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/660d24f1cd0a1100084b9a9f
😎 Deploy Preview https://deploy-preview-9966--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Apr 3, 2024

Code Climate has analyzed commit f8463d1 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival
Copy link
Member Author

vikiival commented Apr 3, 2024

cc @hassnian

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep for now, will raise a PR with separate EDs

@vikiival vikiival merged commit f9fca54 into main Apr 3, 2024
18 of 19 checks passed
@vikiival vikiival deleted the weird-trigger-of-xcm branch April 3, 2024 11:04
This was referenced Apr 4, 2024
This was referenced Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants