Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vue-test-utils and unit test for BalanceInput.vue #3663

Merged
merged 9 commits into from
Aug 8, 2022
Merged

feat: add vue-test-utils and unit test for BalanceInput.vue #3663

merged 9 commits into from
Aug 8, 2022

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged the recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kodabot
Copy link
Collaborator

kodabot commented Aug 4, 2022

SUCCESS @preschian PR for issue #3586 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 4, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 0bb667a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62f0e2eb4fc6d30009dd1a77
😎 Deploy Preview https://deploy-preview-3663--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review August 4, 2022 03:37
@preschian preschian requested review from a team as code owners August 4, 2022 03:37
@preschian preschian requested review from kkukelka and JustLuuuu and removed request for a team August 4, 2022 03:37
kkukelka
kkukelka approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, though not the biggest VTU expert here 😛

components/shared/BalanceInput.test.ts Outdated Show resolved Hide resolved
@kkukelka kkukelka added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 4, 2022
@petersopko petersopko requested review from petersopko and removed request for JustLuuuu August 4, 2022 09:23
@JustLuuuu JustLuuuu added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 4, 2022
petersopko
petersopko suggested changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things please :)

  1. let's delete api.spec.ts since it keeps failing and doesn't do anything (skipping)
  2. please can we move the BalanceInput.test.ts from the components/shared folder to tests?

@petersopko petersopko added S-changes-requested-🤞 PR is almost good to go, just some fine tunning and removed S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Aug 4, 2022
@preschian
Copy link
Member Author

2 things please :)

  1. let's delete api.spec.ts since it keeps failing and doesn't do anything (skipping)
  2. please can we move the BalanceInput.test.ts from the components/shared folder to tests?
  1. will update 👍
  2. because this is a unit test, usually tightly coupled with the component itself, what if we keep placing it beside the component? it will be easier to track which components already have a test case. for integration and e2e test, I think it would be a good fit inside tests folder

@preschian
Copy link
Member Author

@petersopko updated, move the unit test to tests folder 👍

@petersopko
Copy link
Contributor

  1. because this is a unit test, usually tightly coupled with the component itself, what if we keep placing it beside the component? it will be easier to track which components already have a test case. for integration and e2e test, I think it would be a good fit inside tests folder

'I've asked @vikiival about that specific thing (because of location of cypress for example), I guess we want to have tests at the same spot 😆 gonna trust his judgement here

@petersopko petersopko added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Aug 8, 2022
@petersopko
Copy link
Contributor

pay 150 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2022

😍 Perfect, I’ve sent the payout
💵 $150 @ 66.15 USD/KSM ~ 2.268 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x601c874847651b868688bbc8e8cc0495bb6cd9d1faa7d2306340e5cb925d1644

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 8, 2022
@vikiival
Copy link
Member

vikiival commented Aug 8, 2022

gonna trust his judgement here

⌘ + F works in every IDE.

@petersopko petersopko merged commit c4c33a6 into kodadot:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkukelka kkukelka kkukelka approved these changes

@petersopko petersopko petersopko approved these changes

@JustLuuuu JustLuuuu JustLuuuu approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BalanceInput.vue - Unit Test
7 participants
@preschian @kodabot @petersopko @yangwao @vikiival @kkukelka @JustLuuuu