Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cypress github workflow #3689

Merged
merged 17 commits into from
Aug 9, 2022

Conversation

kkukelka
Copy link
Member

@kkukelka kkukelka commented Aug 6, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kodabot
Copy link
Collaborator

kodabot commented Aug 6, 2022

SUCCESS @kkukelka PR for issue #3679 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 6, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 821ac82
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62f22bc797fb4a000910014d
😎 Deploy Preview https://deploy-preview-3689--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kkukelka kkukelka marked this pull request as ready for review August 8, 2022 17:29
@kkukelka kkukelka requested review from a team as code owners August 8, 2022 17:29
@kkukelka kkukelka requested review from prachi00 and JustLuuuu and removed request for a team August 8, 2022 17:29
@kkukelka kkukelka mentioned this pull request Aug 8, 2022
1 task
@kkukelka
Copy link
Member Author

kkukelka commented Aug 8, 2022

@petersopko
some failed tests are being skipped for now to quickly get this into master branch (to prevent further components from breaking in the meantime)
Screenshot 2022-08-08 at 19 26 05

will track this in followup ticket #3701

@kkukelka kkukelka mentioned this pull request Aug 9, 2022
20 tasks
Copy link
Member

@JustLuuuu JustLuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@JustLuuuu JustLuuuu added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 9, 2022
@vikiival
Copy link
Member

vikiival commented Aug 9, 2022

May @petersopko can have a look

@petersopko
Copy link
Contributor

May @petersopko can have a look

I've had a look and I couldn't make the tests fail, I've checked out @kkukelka branch and after removing the .skip commands from tests, I get all green. Reported this also in #3701
image

@codeclimate
Copy link

codeclimate bot commented Aug 9, 2022

Code Climate has analyzed commit 821ac82 and detected 0 issues on this pull request.

View more on Code Climate.

@petersopko
Copy link
Contributor

@kkukelka @vikiival the tests were failing, because in the pipeline instance, somehow it kicked out user out of logged in state before testing the actions on item details. I've solved it by adding one more log in before these tests, temporarily it works and we didn't lose those tests, in the future, obviously more elegant solution will be needed.

Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg 🚀

@petersopko petersopko merged commit 8028654 into kodadot:main Aug 9, 2022
@petersopko petersopko added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 9, 2022
@petersopko
Copy link
Contributor

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Aug 9, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 62.66 USD/KSM ~ 1.596 $KSM
🧗 EqdyzrzVmeHwMdMwvPeCMnNdbuQDbD3YrjY93xq9Ln3jUGW
🔗 0x9bbbd5ddb6b413113aef8d471e19399d2fd69611ad9a414d063122654b0a5bcc

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 9, 2022
@vikiival
Copy link
Member

vikiival commented Aug 9, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect Cypress tests into CI/CD pipeline
6 participants