Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix flaky test #3759

Merged
merged 9 commits into from
Aug 17, 2022
Merged

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes E2E - Flaky test? #3755
  • add cypress-network-idle. make sure to run next steps when the network completed the requests
  • adjust viewportWidth
  • adjust defaultCommandTimeout to 10s
  • adjust retries to 3x

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged the recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kodabot
Copy link
Collaborator

kodabot commented Aug 16, 2022

SUCCESS @preschian PR for issue #3755 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f2b946b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62fca204a6e8db00095a3f2c
😎 Deploy Preview https://deploy-preview-3759--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review August 16, 2022 18:10
@preschian preschian requested review from a team as code owners August 16, 2022 18:10
@preschian preschian requested review from roiLeo and JustLuuuu and removed request for a team August 16, 2022 18:10
@roiLeo roiLeo requested review from petersopko and removed request for JustLuuuu August 16, 2022 20:05
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm & tests pass

I don't know what else to say since I don't have enough experience with cypress.
I'll let peter add comments if needed.

Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I haven't seen the cy.waitForNetworkIdle used before, but if the package doesn't get deprecated, it seems to be exactly what we need :)

@petersopko
Copy link
Contributor

pay 50 usd

@petersopko petersopko added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Aug 17, 2022
@codeclimate
Copy link

codeclimate bot commented Aug 17, 2022

Code Climate has analyzed commit f2b946b and detected 0 issues on this pull request.

View more on Code Climate.

@petersopko petersopko merged commit 44969de into kodadot:main Aug 17, 2022
@yangwao
Copy link
Member

yangwao commented Aug 17, 2022

pay 50

@yangwao
Copy link
Member

yangwao commented Aug 17, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 54.64 USD/KSM ~ 0.915 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xee545bb36386b18db33159060acfa1e4e7b499104c398df0dcaeeb92ae66598d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E - Flaky test?
5 participants