WIP: parallel tests + rmrk stats #4006

petersopko · 2022-09-22T16:55:33Z

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

Bugfix
Feature
Refactoring

What's new?

PR closes E2E - Cypress parallelization #3841, closes E2E - Spotlight / Series Insight / Hot #3681
Requires deployment <rubick/magick_issue>
test parallelization + stats test, coming soon

Before submitting Pull Request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
I've tested PR on mobile and everything seems works
I found edge cases
I've written some unit tests 🧪

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot

My fix has changed something on UI; a screenshot is best to understand changes for others.

netlify · 2022-09-22T16:55:37Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`6391c89`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/633c18683181c80009a19b58
😎 Deploy Preview	https://deploy-preview-4006--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kodabot · 2022-09-22T16:55:37Z

SUCCESS @petersopko PR for issue #3681 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

kodabot · 2022-09-22T16:55:39Z

SUCCESS @petersopko PR for issue #3841 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

cypress · 2022-09-27T13:26:34Z

Test summary

39 • 1 • 9 • 0

Run details


Project	kodadot/nft-gallery
Status	Failed
Commit	`8615500`
Started	Sep 27, 2022 1:22 PM
Ended	Sep 27, 2022 1:26 PM
Duration	03:38 💡
OS	Windows 10.0.22000
Browser	Electron 102

View run in Cypress Dashboard ➡️

Failures

	cypress\e2e\rmrk-simple-mint.cy.ts		1
1	simple mint in rmrk > should able to simple mint

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

petersopko · 2022-09-27T13:30:42Z

✅

petersopko · 2022-10-02T08:00:34Z

I need to ask for help from the pros here, I'm not making much progress on the parallelization part of the PR:

In order to parallelize the tests with cypress (not locally) cypress test needs to be recorded (happening with secret key which is saved in our GH repo already - it can be accessed through ${{ secrets.CYPRESS_RECORD_KEY }}).

However, here's what I'm getting when trying to record our tests to Cypress dashboard:

Is it possible to start passing those keys to forked builds? this way, we can get to a point where the install and cache jobs gets saved in cypress dashboard and parallelized tests will run on virtual machines in the dashboard.
ref: https://docs.cypress.io/guides/guides/parallelization#CI-parallelization-interactions

@kkukelka @preschian I know you guys have worked with both workflows and Cypress before 🙏🏻 I'm trying couple workflows there, feel free to push in any ideas you might have straight to the PR.

kkukelka · 2022-10-03T05:22:26Z

I need to ask for help from the pros here, I'm not making much progress on the parallelization part of the PR:

In order to parallelize the tests with cypress (not locally) cypress test needs to be recorded (happening with secret key which is saved in our GH repo already - it can be accessed through ${{ secrets.CYPRESS_RECORD_KEY }}).

However, here's what I'm getting when trying to record our tests to Cypress dashboard:

Is it possible to start passing those keys to forked builds? this way, we can get to a point where the install and cache jobs gets saved in cypress dashboard and parallelized tests will run on virtual machines in the dashboard. ref: https://docs.cypress.io/guides/guides/parallelization#CI-parallelization-interactions

@kkukelka @preschian I know you guys have worked with both workflows and Cypress before 🙏🏻 I'm trying couple workflows there, feel free to push in any ideas you might have straight to the PR.

i believe you have to set this CYPRESS_RECORD_KEY in the repository as well since we don't push our .env file to remote.
maybe this article can help

preschian · 2022-10-04T08:18:38Z

Is it possible to start passing those keys to forked builds?

hhmm, interesting 🤔. maybe for cypress, we use another platform for CI (https://buildkite.com/ for example) and put that secrets.CYPRESS_RECORD_KEY into that platform

I need to test it out

codeclimate · 2022-10-04T11:26:56Z

Code Climate has analyzed commit 6391c89 and detected 0 issues on this pull request.

View more on Code Climate.

petersopko · 2022-10-04T11:28:38Z

i believe you have to set this CYPRESS_RECORD_KEY in the repository as well since we don't push our .env file to remote. maybe this article can help

it is set as this (kodadot/nft-gallery) secret, I've tried to set it in my fork as well, that didn't do the job

preschian · 2022-10-06T13:20:30Z

seems quite tricky 🤔 some alternative methods:

use https://circleci.com/, "If you are comfortable sharing secrets with anyone who forks your project and opens a PR, you can enable the Pass secrets to builds from forked pull requests option" https://circleci.com/docs/oss#pass-secrets-to-builds-from-forked-pull-requests
use gitlab as ci/cd. cons, need premium account https://docs.gitlab.com/ee/ci/ci_cd_for_external_repos/github_integration.html

petersopko · 2022-10-07T08:55:15Z

use https://circleci.com/, "If you are comfortable sharing secrets with anyone who forks your project and opens a PR, you can enable the Pass secrets to builds from forked pull requests option" https://circleci.com/docs/oss#pass-secrets-to-builds-from-forked-pull-requests

This would also enable the native Cypress solution 😄 I'd rather stick with that then

use gitlab as ci/cd. cons, need premium account https://docs.gitlab.com/ee/ci/ci_cd_for_external_repos/github_integration.html

Generally speaking, it would be better in my opinion to stick with one solution for E2E tests -> from actual tests to parallelization. @yangwao could we pass the cypress secret (saved in this repo) to other forks?

This would be the solution here, without requiring another CI/CD service (just Cypress + GH)

petersopko · 2022-10-20T09:36:43Z

expanding e2e test suite makes no sense without parallelization, this needs to get revisited once somebody manages to do that

petersopko added 10 commits September 21, 2022 16:01

build artifact test

af64b7e

build artifact test 2

a0a44a5

build artifact test 3

52c97cd

build artifact test 4

c138a22

test pnpm cache 1

5cc3b40

test pnpm cache 2

940d320

test pnpm cache 3

db2b279

add env cypress cache folder

24ddc5b

download cached pnpm

3922aad

cypress dashboard?

16487ac

petersopko and others added 9 commits September 22, 2022 19:21

Merge branch 'main' into parallel-tests

85b04b2

cypress record key

78a4f01

✅ new custom tags + <p> wrapping

a8ca019

✅ some tests

2ab398e

⚡ spotlight v1 done

a07e92c

Merge remote-tracking branch 'upstream/main' into parallel-tests

26c251e

🚧 live cypress dashboard test

76641bb

Merge branch 'main' into parallel-tests

c982015

🚧 maybe gh token

8615500

petersopko added 6 commits September 27, 2022 15:32

🚧 another parallel attempt

426cc7c

Merge branch 'main' into parallel-tests

98db2af

🚧 add prefix

83787e6

✅ introduce series test

56072cc

✅ tags are alive

7f31e17

✅ default sort

332a232

petersopko added 2 commits September 30, 2022 16:12

✅ more sorts at series

4ac3e1a

✅ all the filters at series

0ebc2de

petersopko and others added 3 commits October 4, 2022 07:19

Merge branch 'main' into parallel-tests

699f549

🎨 cosmetics

a910cc3

Merge remote-tracking branch 'origin/parallel-tests' into parallel-tests

48b3d22

🎨 typo

6391c89

petersopko closed this Oct 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: parallel tests + rmrk stats #4006

WIP: parallel tests + rmrk stats #4006

petersopko commented Sep 22, 2022

netlify bot commented Sep 22, 2022 •

edited

Loading

kodabot commented Sep 22, 2022

kodabot commented Sep 22, 2022

cypress bot commented Sep 27, 2022

petersopko commented Sep 27, 2022

petersopko commented Oct 2, 2022

kkukelka commented Oct 3, 2022

preschian commented Oct 4, 2022

codeclimate bot commented Oct 4, 2022

petersopko commented Oct 4, 2022

preschian commented Oct 6, 2022

petersopko commented Oct 7, 2022

petersopko commented Oct 20, 2022

WIP: parallel tests + rmrk stats #4006

WIP: parallel tests + rmrk stats #4006

Conversation

petersopko commented Sep 22, 2022

PR type

What's new?

Before submitting Pull Request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot

netlify bot commented Sep 22, 2022 • edited Loading

✅ Deploy Preview for koda-nuxt ready!

kodabot commented Sep 22, 2022

kodabot commented Sep 22, 2022

cypress bot commented Sep 27, 2022

Test summary

Run details

Failures

petersopko commented Sep 27, 2022

petersopko commented Oct 2, 2022

kkukelka commented Oct 3, 2022

preschian commented Oct 4, 2022

codeclimate bot commented Oct 4, 2022

petersopko commented Oct 4, 2022

preschian commented Oct 6, 2022

petersopko commented Oct 7, 2022

petersopko commented Oct 20, 2022

netlify bot commented Sep 22, 2022 •

edited

Loading