Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5103 add back mintnft activity #5104

Merged
merged 2 commits into from
Feb 26, 2023

Conversation

maderi21
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@maderi21 maderi21 requested a review from a team as a code owner February 23, 2023 09:50
@maderi21 maderi21 requested review from preschian and Jarsen136 and removed request for a team February 23, 2023 09:50
@kodabot
Copy link
Collaborator

kodabot commented Feb 23, 2023

SUCCESS @maderi21 PR for issue #5103 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f5b17ac
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63fb443cd5c16d0008b8e350
😎 Deploy Preview https://deploy-preview-5104--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Feb 23, 2023

Code Climate has analyzed commit ce9520e and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor

It's related with #5028
I'm thinking if we should hide mint and burns on the tabs of activity on rmrk2. WDYT @roiLeo

tested on: https://deploy-preview-5104--koda-nuxt.netlify.app/rmrk2/gallery/16759320-8453d0ccb4cb7e9e59-A51-THE_FOUNDRY-00000246?page=1

image

@roiLeo
Copy link
Contributor

roiLeo commented Feb 23, 2023

It's related with #5028 I'm thinking if we should hide mint and burns on the tabs of activity on rmrk2. WDYT @roiLeo

Why? I find it important to have information of the mint date.
more or less the same thing for burn

@maderi21
Copy link
Contributor Author

It's related with #5028 I'm thinking if we should hide mint and burns on the tabs of activity on rmrk2. WDYT @roiLeo

Why? I find it important to have information of the mint date. more or less the same thing for burn

why was it hidden on rmrk2?

@Jarsen136
Copy link
Contributor

It's related with #5028 I'm thinking if we should hide mint and burns on the tabs of activity on rmrk2. WDYT @roiLeo

Why? I find it important to have information of the mint date. more or less the same thing for burn

@vikiival may tell us if we could have the mint and burns information on rmrk2.

related changes:
image

@roiLeo
Copy link
Contributor

roiLeo commented Feb 23, 2023

why was it hidden on rmrk2?

I think it's because interaction changed on rmrk2 compared to v1
MINTNFT => MINT
CONSUME => BURN

@maderi21
Copy link
Contributor Author

why was it hidden on rmrk2?

I think it's because interaction changed on rmrk2 compared to v1 MINTNFT => MINT CONSUME => BURN

I've checked the indexer and currently, I don't think there are burn events indexed?
image

Mints are present however, maybe let's create a new issue for handling of the newly named events in gallery item? I can work on it. wdyt @Jarsen136 @roiLeo

@roiLeo
Copy link
Contributor

roiLeo commented Feb 23, 2023

I've checked the indexer and currently, I don't think there are burn events indexed?

This indexer is still in beta some of the features are not correctly implemented.
Like BURN event isn't handled yet.

@maderi21
Copy link
Contributor Author

what should be done here to move this forward ? 🤔 are we hiding the tabs for rmrk2? or altering it somehow else ?

@vikiival vikiival merged commit 550767d into kodadot:main Feb 26, 2023
@maderi21
Copy link
Contributor Author

👀 @vikiival

@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 37.45 USD/KSM ~ 0.801 $KSM
🧗 JHJGu2aWyAFBfcso8bR7ma82p15YAavyN6vQfJyWuhniNGa
🔗 0x2140c978ce363ebeb725895990cfb28492cc1961acde8b2aec3a22bd8b431f01

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing MINT event in Activity table
6 participants