Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add parent tab to GalleryItemDescription #5735

Merged

Conversation

Matehoo
Copy link
Contributor

@Matehoo Matehoo commented Apr 20, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2023-04-21 at 08 48 19

Copilot Summary

🤖 Generated by Copilot at 5ea0663

This pull request adds the functionality to display the parent NFT of a gallery item, if it exists, in a new tab on the gallery item page. It modifies the useGalleryItem function, the NFT interface, and several GraphQL queries to fetch and handle the parent NFT data. It also adds a new translation key and some styles for the parent tab.

🤖 Generated by Copilot at 5ea0663

Sing, O Muse, of the skillful code that added parent to the NFT
And how it fetched the metadata of the ancient and the new
With fragments and queries, the useGalleryItem function was enhanced
To show the nested NFTs and their origin in the gallery view

@Matehoo Matehoo requested a review from a team as a code owner April 20, 2023 07:40
@Matehoo Matehoo requested review from vikiival and Jarsen136 and removed request for a team April 20, 2023 07:40
@kodabot
Copy link
Collaborator

kodabot commented Apr 20, 2023

WARNING @Matehoo PR for issue #5673 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5673

@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3f79df4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64468542190d5a0008af1e55
😎 Deploy Preview https://deploy-preview-5735--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 20, 2023

AI-Generated Summary: This pull request introduces a new parent tab to the GalleryItemDescription component. The parent tab displays the parent NFT's media item and name if a parent NFT exists. The patch includes updates to GraphQL queries to fetch parent NFT data, relevant styles for the new parent item, and changes to the GalleryItemDescription.vue and useGalleryItem.ts files to support the new parent tab. Additionally, the "Parent" label has been added to the localization files for English translations.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Apr 20, 2023
queries/nftById.graphql Outdated Show resolved Hide resolved
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise ok

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise ok

@reviewpad reviewpad bot added small Pull request is small and removed medium Pull request is medium labels Apr 20, 2023
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@exezbcz
Copy link
Member

exezbcz commented Apr 21, 2023

The 4 tab selection will be a bit tricky on mobile but I will deliver design for this, created follow up that will solve this:

dont want to hold this pr just because of that, feel free to merge I guess

@vikiival
Copy link
Member

@Matehoo can you share a link that you used for testing ?

@Matehoo
Copy link
Contributor Author

Matehoo commented Apr 21, 2023

@Matehoo can you share a link that you used for testing ?

if you mean what nft i used http://localhost:9090/ksm/gallery/17528332-3a4100ce6c6ae0292c-KDWINGS-RHAEGAL_GREEN_WINGS-0000000000000096

@yangwao yangwao mentioned this pull request Apr 22, 2023
@vikiival
Copy link
Member

cc @Matehoo can you please resolve conflicts

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Apr 24, 2023
@codeclimate
Copy link

codeclimate bot commented Apr 24, 2023

Code Climate has analyzed commit 3f79df4 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 7536174 into kodadot:main Apr 24, 2023
@vikiival vikiival mentioned this pull request Apr 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show parent nft in the item detail
6 participants