-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add parent tab to GalleryItemDescription #5735
feat: Add parent tab to GalleryItemDescription #5735
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request introduces a new parent tab to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise ok
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
The 4 tab selection will be a bit tricky on mobile but I will deliver design for this, created follow up that will solve this: dont want to hold this pr just because of that, feel free to merge I guess |
@Matehoo can you share a link that you used for testing ? |
if you mean what nft i used http://localhost:9090/ksm/gallery/17528332-3a4100ce6c6ae0292c-KDWINGS-RHAEGAL_GREEN_WINGS-0000000000000096 |
cc @Matehoo can you please resolve conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go
Code Climate has analyzed commit 3f79df4 and detected 0 issues on this pull request. View more on Code Climate. |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 5ea0663
This pull request adds the functionality to display the parent NFT of a gallery item, if it exists, in a new tab on the gallery item page. It modifies the
useGalleryItem
function, theNFT
interface, and several GraphQL queries to fetch and handle the parent NFT data. It also adds a new translation key and some styles for the parent tab.🤖 Generated by Copilot at 5ea0663