Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massmint - Table + Edit Panel + Dialogs #5765

Merged
merged 58 commits into from
May 10, 2023
Merged

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Apr 22, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Testing

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

2023-04-27_13-58
2023-04-27_14-00
2023-04-27_14-01
2023-04-27_14-01_1
2023-04-27_14-02
2023-04-27_14-02_1
2023-04-27_14-03
2023-04-27_14-03_1
2023-04-27_14-03_2
2023-04-27_14-04

Copilot Summary

🤖 Generated by Copilot at 77d56d2

This pull request implements the mass mint feature for the NFT gallery, which allows users to upload a zip file of images and mint multiple NFTs with metadata. It adds and modifies several components, such as Massmint, OverviewTable, EditPanel, and various modals, to handle the user interface and logic of the feature. It also adds some types, utility classes, and props to the NeoModal and NeoSidebar components to support the feature.

🤖 Generated by Copilot at 77d56d2

We are the masters of the mint
We create and destroy with a click
We unleash the power of the NFT
We rule the gallery with the NeoModal and the NeoSidebar

@daiagi daiagi requested a review from a team as a code owner April 22, 2023 13:04
@daiagi daiagi requested review from roiLeo and Jarsen136 and removed request for a team April 22, 2023 13:04
@kodabot
Copy link
Collaborator

kodabot commented Apr 22, 2023

WARNING @daiagi PR for issue #5180 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5180

@kodabot
Copy link
Collaborator

kodabot commented Apr 22, 2023

SUCCESS @daiagi PR for issue #5181 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@kodabot
Copy link
Collaborator

kodabot commented Apr 22, 2023

SUCCESS @daiagi PR for issue #5182 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d5fb4e6
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645b61454271200008c9c179
😎 Deploy Preview https://deploy-preview-5765--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 22, 2023

AI-Generated Summary: This pull request introduces several improvements and new features to the project, including:

  1. Enhancements to the user interface for minting NFTs, adding new key-value pairs in the en.json locale file.
  2. New Vue components: DeleteModal, EditPanel, MissingInfoModal, ReviewModal, and MintingModal, handling various user interactions and modals.
  3. Significant updates to the OverviewTable.vue component for better NFT information display and improved user experience.
  4. Additional CSS classes for styling and theming.
  5. Introduction of new types for handling NFT data: Status and NFT.
  6. Modification of existing NeoSidebar and NeoModal components for greater customization and functionality.
  7. Changes to Massmint.vue file, integrating new components and methods for better overall functionality.

Overall, this pull request provides a more polished user experience and expanded feature set for mass minting NFTs.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Apr 22, 2023
@daiagi daiagi changed the title Feature/massmint overview table Massmint - Table + Edit Panel + Dialogs Apr 22, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Apr 22, 2023

It doesn't actually mint yest

@exezbcz
Copy link
Member

exezbcz commented Apr 22, 2023

hey hey, nice job! Mass mint almost done!

Feedback

  • it will be bit harder for my since I did not fully make the designs, but I will do my best to identify the issues

  • I would maybe remove the footer completely on mass mint and these subpages

  • should scroll be enabled when edit sidebar is opened?
    image

  • can you please add some padding into the text container
    image

image

  • this text to normal weight

please see this screen:
image

  • the column names should be grey, operation icons as well
  • divider to grey please as well
    image

image

  • picture preview should work the same as on gallery cards - that means the img is scaled, not stretched

description input limit missing
image

the sidebar is too wide, can you make it smaller please

image

  • the input fields should have more height - similar for example to the buy button in gallery item detail:
    image

the tags are bit different from the design
image

  • we can maybe use the same that are in collection activity - with a change of the pink to more red-ish color (#FFB6B6)
  • they have also dark mode alternative
    image
    image

I may notice something else, but these are some starting points:D

@preschian
Copy link
Member

preschian commented May 3, 2023

btw, not sure what's up with DeepSource
all of these issues are wrong (i.e not true, the vars are used)

seems like DeepSource is unable to scan the .vue component properly. imo, CodeClimate also unable to scan composable function properly

@daiagi
Copy link
Contributor Author

daiagi commented May 3, 2023

@preschian do you have any idea what to do to solve it?

@preschian
Copy link
Member

@preschian do you have any idea what to do to solve it?

no idea, I think it is safe to ignore for that case

@daiagi
Copy link
Contributor Author

daiagi commented May 4, 2023

image

@daiagi daiagi mentioned this pull request May 5, 2023
16 tasks
@daiagi
Copy link
Contributor Author

daiagi commented May 6, 2023

@vikiival why no merge?

components/massmint/useMassMint.ts Show resolved Hide resolved
components/massmint/useMassMint.ts Outdated Show resolved Hide resolved
components/massmint/useMassMint.ts Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit d5fb4e6 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@vikiival vikiival merged commit e5b3b2a into main May 10, 2023
@vikiival vikiival deleted the feature/massmint-overview-table branch May 10, 2023 12:34
@vikiival
Copy link
Member

Pinging @yangwao about payout

@yangwao
Copy link
Member

yangwao commented May 13, 2023

pay 200 usd

@yangwao
Copy link
Member

yangwao commented May 13, 2023

😍 Perfect, I’ve sent the payout
💵 $200 @ 24.95 USD/KSM ~ 8.016 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0xeb2ecffae95774e71deb9d8a36aeeea2b6075d2e0c388568b566be24eb321b72

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass Mint: Dialogs Mass Mint: Edit Panel Mass Mint: step 4 - Overview table
10 participants