-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Activity event improvements #5801
Conversation
SUCCESS @Jarsen136 PR for issue #5775 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request includes changes related to activity event improvements in the Events.vue, EventRowAvatar.vue, EventRowDesktop.vue, and EventRowTablet.vue files. The modifications introduce stylesheet adjustments, refined code structure, and enhanced layout for desktop and tablet views. Overall, the update aims to refine the visual representation of activity events and improve the associated user experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure the preview is square all the time and check if the preview does not stretch the imgs, but scale them
I think EventRowAvatar
is missing object-fit: cover;
- I think
EventRowAvatar
can be made intoNeoAvatar
component
and can be used in Activity, MassMint, notifications, more?
done
✅ I have added |
Code Climate has analyzed commit 90af86d and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... not sure about that NeoAvatar
this name would refer to Identity Avatar to me.
I would keep it outside libs/ui
for now
What if we want to use lazy loading on these images?
otherwise lgtm ✅
IMO, this component could also be used for displaying the Identity avatar if we give it proper props. So, let's leave it here for now ?
Then we need to introduce |
Not the same purposes but we can keep it if you like
fyi |
Thanks for correcting me. Then it would need another lazy load package supported vue3. |
pay 50 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at e83d93e
Refactored and improved the layout and responsiveness of the collection activity event components. Used props, utility classes, and flexbox to control the size, alignment, and overflow of the avatar, event, and text elements. Modified
EventRowAvatar.vue
,EventRowDesktop.vue
,EventRowTablet.vue
, andEvents.vue
.🤖 Generated by Copilot at e83d93e