Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5811 Make currency in item tabs as column name #5812

Merged
merged 10 commits into from
May 3, 2023
Merged

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Apr 26, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2023-04-25 at 9 52 31 PM

Copilot Summary

🤖 Generated by Copilot at b5d30e1

This pull request enhances the price display in the gallery item activity table by adding the KSM unit and removing redundant symbols. It also refactors the offers table component and moves it to GalleryItemActivityTable.vue.

🤖 Generated by Copilot at b5d30e1

Sing, O Muse, of the skillful coder who refined the price display
In the gallery item activity table, where the offers of KSM are made
He added the unit to the column, as clear as the sun-god's ray
And hid the symbol from the token, as stealthy as Hermes' blade

@kodabot
Copy link
Collaborator

kodabot commented Apr 26, 2023

SUCCESS @prachi00 PR for issue #5811 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5b6e0b2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645283211ed1d100089d3b62
😎 Deploy Preview https://deploy-preview-5812--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 26, 2023

AI-Generated Summary: This pull request addresses issue #5811 and includes 4 patches. The changes involve adding currency (KSM) to column names in GalleryItemActivityTable.vue and GalleryItemOffers.vue components, temporarily hiding the unit symbol and modifying the DisablableTab.scss file. Additionally, it includes fixes for conflict markers and a removal of a console.log statement.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 26, 2023
@prachi00 prachi00 requested a review from a team as a code owner April 28, 2023 02:35
@prachi00 prachi00 requested review from roiLeo, vikiival and floyd-li and removed request for a team April 28, 2023 02:35
@floyd-li
Copy link
Member

@prachi00 prachi00 requested a review from roiLeo April 28, 2023 06:51
Copy link
Member

@floyd-li floyd-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix deepscan, otherwise lgtm

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please delete commented features

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • deepscan issues
  • remove unused code
  • & const token = price

otherwise wfm ✅

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 28, 2023
@prachi00
Copy link
Member Author

prachi00 commented May 3, 2023

can we merge this?

@codeclimate
Copy link

codeclimate bot commented May 3, 2023

Code Climate has analyzed commit a7adf52 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit b557077 into main May 3, 2023
@vikiival vikiival deleted the feat-unit-hide branch May 3, 2023 15:52
@vikiival
Copy link
Member

vikiival commented May 3, 2023

pay 22 usd

@prachi00
Copy link
Member Author

prachi00 commented May 3, 2023

@vikiival seems the payment failed

@vikiival
Copy link
Member

vikiival commented May 3, 2023

pay 22 usd

@prachi00
Copy link
Member Author

prachi00 commented May 3, 2023

oh I didnt have address added in payout link, just added it, can you try again now 🫣 @vikiival

@vikiival
Copy link
Member

vikiival commented May 3, 2023

pay 22 usd

@yangwao
Copy link
Member

yangwao commented May 3, 2023

😍 Perfect, I’ve sent the payout
💵 $22 @ 28.32 USD/KSM ~ 0.777 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x5a76a964e26e0178317e92f4dc19632eedda4dbc183f06fd759f5743f2f72188

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 3, 2023
@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make currency in item tabs as column name
7 participants