-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unit display on snek network #5821
Conversation
SUCCESS @Jarsen136 PR for issue #5819 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request contains a change in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about that one:
// '0' if paying in bsx (on Basilisk and Snek)
// '1' if paying in ksm (on basilisk)
// '5' if paying in ksm (on Snek)
Could you pls review this? @vikiival 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would point to Phala token on snek
Code Climate has analyzed commit d7706a7 and detected 0 issues on this pull request. View more on Code Climate. |
Thanks for checking the query. Then I got the root reason why it does not work. Please review the code again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wfm, I think I'll remove this plugin in #5655
cc @roiLeo |
My bet is that someone changed the token number for snek (propably check assetList) |
I think I made a change recently on edit: issue with |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
unit
display onsnek
item #5819Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 4408de1
Removed hardcoded value from
getKusamaAssetId
function inutils/api/bsx/query.ts
. This allows the function to return the correct asset id for the Kusama network based on the input network name.🤖 Generated by Copilot at 4408de1