Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable RMRK2 on production - kodadot.xyz #5892

Merged
merged 2 commits into from
May 10, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 9, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 4b2b892

Simplified the logic for filtering out chains based on the environment in utils/chain.ts. Removed the unused disableChainListOnProductionEnv variable and condition.

🤖 Generated by Copilot at 4b2b892

disableChainList
gone, only one check remains
code is simpler now

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 9, 2023 17:52
@Jarsen136 Jarsen136 requested review from roiLeo and daiagi and removed request for a team May 9, 2023 17:52
@kodabot
Copy link
Collaborator

kodabot commented May 9, 2023

SUCCESS @Jarsen136 PR for issue #5887 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 16c32fe
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645afa28775113000780d74d
😎 Deploy Preview https://deploy-preview-5892--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 9, 2023

AI-Generated Summary: This pull request updates the utils/chain.ts to enable RMRK2 on the production environment for kodadot.xyz. The patch removes the previously disabled chain list for the production environment and changes the condition for both production and beta environments to use the same disableChainListOnBetaEnv.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 9, 2023
@yangwao
Copy link
Member

yangwao commented May 9, 2023

and can we set it as default?

so when someone opens kodadot.xyz it will switch them to rmrk2 :)

thanks!

@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit 16c32fe and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

and can we set it as default?

so when someone opens kodadot.xyz it will switch them to rmrk2 :)

thanks!

✅ Done

@yangwao
Copy link
Member

yangwao commented May 10, 2023

pay 20 usd

let's go

@yangwao yangwao merged commit 557478e into kodadot:main May 10, 2023
@yangwao
Copy link
Member

yangwao commented May 10, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 25.58 USD/KSM ~ 0.782 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x58b3001232d498cbeaac1f53a86c5e2bb7c9d850757dab8c505a27f5e088893c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable RMRK2 on production - kodadot.xyz
4 participants