-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unable to make offer due to balance issue #5953
Conversation
SUCCESS @Jarsen136 PR for issue #5938 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request addresses a balance issue that prevented users from making offers. The changes include updating the GalleryItemOffer.vue file by refactoring the balance computation, using the getAsssetBalance() function from the API, and fetching the balance on component mount. This ensures that the user's balance is accurately displayed and allows them to make offers successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please could you use pinia storage to fetch & get balance so we can share the value between components
components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemOffer.vue
Show resolved
Hide resolved
components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemOffer.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: Unable to retrieve keypair '...'
Warning poping on snek, I don't think it's related to this PR
It should be fixed now, as I merged the main branch into this one. |
Still not working for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked after clearing local storage
Code Climate has analyzed commit a5ee83f and detected 0 issues on this pull request. View more on Code Climate. |
pay 15 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at dc1efde
Improved offer functionality and code quality in
GalleryItemOffer.vue
. Fixed a balance update bug.🤖 Generated by Copilot at dc1efde