Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➖ remove getSetting #5999

Merged
merged 11 commits into from
May 17, 2023
Merged

➖ remove getSetting #5999

merged 11 commits into from
May 17, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 15, 2023

@roiLeo roiLeo requested a review from a team as a code owner May 15, 2023 14:32
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team May 15, 2023 14:32
@netlify
Copy link

netlify bot commented May 15, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ae20330
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6464798c05d06f0008a3691b
😎 Deploy Preview https://deploy-preview-5999--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 15, 2023

AI-Generated Summary: This pull request removes getSetting and makes changes to useApi.ts, transfer.vue, WithKeyring.ts, and apiUrlMixin.ts. The update simplifies the way the API URL is computed and removes unnecessary getter methods while handling default values in a more efficient manner.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 15, 2023
Jarsen136
Jarsen136 reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a default value DEFAULT_PREFIX for the urlPrefix, so we do need to set ksm again

composables/useApi.ts Outdated Show resolved Hide resolved
vikiival
vikiival reviewed May 15, 2023
View reviewed changes
utils/WithKeyring.ts Outdated Show resolved Hide resolved
vikiival
vikiival reviewed May 16, 2023
View reviewed changes
utils/WithKeyring.ts Outdated Show resolved Hide resolved
vikiival
vikiival reviewed May 16, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarification

@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels May 16, 2023
@codeclimate
Copy link

codeclimate bot commented May 16, 2023

Code Climate has analyzed commit ebac445 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

[heavy breathing]

@roiLeo roiLeo merged commit a5cdaac into kodadot:main May 17, 2023
@roiLeo roiLeo deleted the chore/settings/getSetting branch May 17, 2023 06:52
This was referenced May 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of the getSettings
3 participants
@roiLeo @vikiival @Jarsen136