Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide collections with empty metadata #6014

Merged
merged 1 commit into from
May 16, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 16, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at /stmn/explore/collectibles
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

Copilot Summary

🤖 Generated by Copilot at bfdc18d

Added metadata filters to collectionList and collectionListWithSearch queries to enable more refined gallery and search features. Updated queries/subsquid/general/collectionListWithSearch.graphql file accordingly.

🤖 Generated by Copilot at bfdc18d

We search for the hidden treasures
In the gallery of doom
We filter by the metadata
To reveal the ancient runes

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 16, 2023 16:31
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team May 16, 2023 16:31
@kodabot
Copy link
Collaborator

kodabot commented May 16, 2023

SUCCESS @Jarsen136 PR for issue #5974 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 16, 2023
@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit bfdc18d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6463afcd68987e0008bde408
😎 Deploy Preview https://deploy-preview-6014--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 16, 2023

AI-Generated Summary: This pull request includes a fix to hide collections with empty metadata. Two lines of code are added to the collectionListWithSearch.graphql file, which ensures that collections only display if their metadata is not null.

@codeclimate
Copy link

codeclimate bot commented May 16, 2023

Code Climate has analyzed commit bfdc18d and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 5454680 into kodadot:main May 16, 2023
@vikiival
Copy link
Member

pay 10 usd

This was referenced May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide collections with empty metadata ^-^
3 participants