Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skeleton card variant size #6023

Merged
merged 3 commits into from
May 18, 2023
Merged

fix: skeleton card variant size #6023

merged 3 commits into from
May 18, 2023

Conversation

leo-anderson-x
Copy link
Contributor

@leo-anderson-x leo-anderson-x commented May 17, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Context

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

CleanShot 2023-05-17 at 21 55 55@2x

Copilot Summary

🤖 Generated by Copilot at c387729

Improved the layout and styling of the NFT card skeleton components in NeoNftCard.vue. Added a skeleton for the NFT title and separated the skeleton for the NFT price.

🤖 Generated by Copilot at c387729

Skeletons aligned
nft-media-info class
Winter of the NFT

@leo-anderson-x leo-anderson-x requested a review from a team as a code owner May 17, 2023 13:06
@leo-anderson-x leo-anderson-x requested review from preschian and Jarsen136 and removed request for a team May 17, 2023 13:06
@kodabot
Copy link
Collaborator

kodabot commented May 17, 2023

SUCCESS @leo-anderson-x PR for issue #6017 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 17, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 36917f2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64665fed1a2b5000089f0f1a
😎 Deploy Preview https://deploy-preview-6023--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 17, 2023

AI-Generated Summary: This pull request includes a single patch that fixes the skeleton card variant size in NeoNftCard.vue. The patch adds 11 new lines and modifies 2 existing lines, introducing new styling and conditional rendering to properly adjust the skeleton card's size according to the variant property.

Jarsen136
Jarsen136 reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

libs/ui/src/components/NeoNftCard/NeoNftCard.vue Outdated Show resolved Hide resolved
@leo-anderson-x @Jarsen136
rewrite class
7503875 
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@codeclimate
Copy link

codeclimate bot commented May 18, 2023

Code Climate has analyzed commit 7503875 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

pay 20 usd

@vikiival vikiival enabled auto-merge May 18, 2023 17:27
@yangwao
Copy link
Member

yangwao commented May 18, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 25.99 USD/KSM ~ 0.77 $KSM
🧗 DzUbHCk3Fr3XdCPNKo7uCJvtBH7YfgiFbn4Gr3VmCMiFy1C
🔗 0xbc38aed3a0d434de9c60daeb7a3282774568b3bd02060e2ac9e013e06173d151

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 18, 2023
@vikiival vikiival merged commit a63539a into kodadot:main May 18, 2023
This was referenced May 25, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 left review comments

@preschian preschian preschian approved these changes

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong loading skeleton card size
7 participants
@leo-anderson-x @kodabot @vikiival @yangwao @preschian @Jarsen136 @exezbcz