Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6043 dark skeleton #6044

Merged
merged 1 commit into from
May 21, 2023
Merged

#6043 dark skeleton #6044

merged 1 commit into from
May 21, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented May 19, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
Screen Shot 2023-05-18 at 8 15 39 PM

Copilot Summary

🤖 Generated by Copilot at 22f6db0

Added a background gradient animation to the NFT card loading placeholders using the theme variables. This change enhances the UI of the NeoSkeleton component.

🤖 Generated by Copilot at 22f6db0

ktheme gradient
animates the skeleton
winter's placeholder

@prachi00 prachi00 requested a review from a team as a code owner May 19, 2023 03:17
@prachi00 prachi00 requested review from roiLeo and daiagi and removed request for a team May 19, 2023 03:17
@kodabot
Copy link
Collaborator

kodabot commented May 19, 2023

SUCCESS @prachi00 PR for issue #6043 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 19, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 22f6db0
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6466ea3715394b000869a3c1
😎 Deploy Preview https://deploy-preview-6044--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 19, 2023
@codeclimate
Copy link

codeclimate bot commented May 19, 2023

Code Climate has analyzed commit 22f6db0 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 19, 2023

AI-Generated Summary: This pull request updates the NeoSkeleton.scss file, specifically adding a new background size, a gradient effect, and a theme inclusion for the neo-skeleton-item class. A total of 10 insertions and 1 deletion have been incorporated.

@daiagi daiagi added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 21, 2023
@vikiival vikiival enabled auto-merge May 21, 2023 11:21
@vikiival vikiival disabled auto-merge May 21, 2023 11:21
@vikiival vikiival merged commit 42fc5e8 into main May 21, 2023
@vikiival vikiival deleted the feat-dark-skeleton branch May 21, 2023 11:21
@vikiival
Copy link
Member

pay 25 usd

@prachi00
Copy link
Member Author

@vikiival bot failed it seems

This was referenced May 25, 2023
@yangwao
Copy link
Member

yangwao commented May 25, 2023

@prachi00
Copy link
Member Author

@yangwao updated the payout link in the pr template with dot address, can we try now?

PS. should we update the payout bot link to new format with dot then? I can do that

@yangwao
Copy link
Member

yangwao commented May 25, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented May 25, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 5.26 USD/DOT ~ 5.703 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0x653982ff10ab0151faee27870ba577581dcbc20cc33b0a91b7e35231bec571fb

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 25, 2023
@yangwao
Copy link
Member

yangwao commented May 25, 2023

PS. should we update the payout bot link to new format with dot then? I can do that

it's already made :) but if you spot where we have KSM, feel free to update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton dark mode
6 participants