Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 video media item #6061

Merged
merged 3 commits into from
May 23, 2023
Merged

🔧 video media item #6061

merged 3 commits into from
May 23, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 21, 2023

fix /stmn/gallery/18-1

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at /stmn/gallery/18-1

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 24d68c2

This pull request enhances the VideoMedia component to accept a src prop for video sources and fixes a minor bug in useGalleryItem.ts where a console log statement was left in.

🤖 Generated by Copilot at 24d68c2

VideoMedia props
More flexible and robust
Debugging, remove

@roiLeo roiLeo requested a review from a team as a code owner May 21, 2023 16:09
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team May 21, 2023 16:09
@netlify
Copy link

netlify bot commented May 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 137ba08
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646c5d86ffe085000811c62b
😎 Deploy Preview https://deploy-preview-6061--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 21, 2023

AI-Generated Summary: This pull request includes changes to the useGalleryItem.ts and VideoMedia.vue files, adding a console.log statement for debugging purposes in the former, and modifying the src attribute of the video element in the latter. Additionally, the src prop is introduced in the VideoMedia.vue component. Overall, there are 3 insertions and 1 deletion in this patch.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented May 21, 2023

Code Climate has analyzed commit f6617a2 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor

fix /stmn/gallery/18-1

Could you also fix the video media item on the collection view? For example, on page /stmn/collection/18. I think they are related to the same issue.

image

@roiLeo
Copy link
Contributor Author

roiLeo commented May 22, 2023

fix /stmn/gallery/18-1

Could you also fix the video media item on the collection view? For example, on page /stmn/collection/18. I think they are related to the same issue.

I already tried but can't find the root cause, maybe something we don't pass animationUrl as prop in NeoNftCard

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least fixed the media item in details page

@roiLeo roiLeo merged commit 3705689 into kodadot:main May 23, 2023
This was referenced May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants