Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add dot in sidebar #6098

Merged
merged 2 commits into from
May 25, 2023
Merged

fix: re-add dot in sidebar #6098

merged 2 commits into from
May 25, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented May 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Copilot Summary

🤖 Generated by Copilot at 878b734

This pull request adds Polkadot integration to the NFT gallery. It enables the display and fetching of Polkadot balances in the MultipleBalances.vue component and the identity.ts store.

🤖 Generated by Copilot at 878b734

Sing, O Muse, of the code that was changed by the skillful developer
Who added support for the Polkadot chain and its token, the dot
And simplified the fiat value calculation with a tokenMap clever
And a generic getter to fetch the current price of any token, a lot

@kodabot
Copy link
Collaborator

kodabot commented May 24, 2023

SUCCESS @preschian PR for issue #6091 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9d7e448
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646f250fb426ba00084fd6e3
😎 Deploy Preview https://deploy-preview-6098--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added the small Pull request is small label May 24, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 24, 2023

AI-Generated Summary: This pull request includes changes to fix the missing dot in the sidebar. It modifies two files, components/balance/MultipleBalances.vue and stores/identity.ts. The changes re-add the 'dot' value in the mapToPrefix object and update the ChainType and ChainToken types to include 'polkadot'. The calculateUsd function now calls fiatStore.getCurrentTokenValue(token) instead of checking for the specific tokens 'KSM' and 'BSX'. Additionally, the pull request adds 'dot' to DEFAULT_BALANCE_STATE and 'polkadot' with token 'DOT' to multiBalanceAssets. Overall, this should resolve the issue of the missing dot in the sidebar.

@preschian preschian marked this pull request as ready for review May 24, 2023 12:06
@preschian preschian requested a review from a team as a code owner May 24, 2023 12:06
@preschian preschian requested review from roiLeo and daiagi and removed request for a team May 24, 2023 12:06
@yangwao
Copy link
Member

yangwao commented May 24, 2023

I would suggest put chain name with smaller caps and ticket can be UPPPERCAPS

It's rule of thumb among traders.

image

otherwise LGTM!

@exezbcz
Copy link
Member

exezbcz commented May 24, 2023

@yangwao agree

good job!

@preschian
Copy link
Member Author

chain name with smaller caps and ticket can be UPPPERCAPS

sry, I didn't understand the requirements. something like this? or capitalize? or something else?
image

@yangwao
Copy link
Member

yangwao commented May 24, 2023

something like this?

yes, works!

@roiLeo
Copy link
Contributor

roiLeo commented May 24, 2023

prefer for capitalize if possible

@exezbcz
Copy link
Member

exezbcz commented May 24, 2023

First letter capital?

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, first letter capital plsky

@codeclimate
Copy link

codeclimate bot commented May 25, 2023

Code Climate has analyzed commit 9d7e448 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented May 25, 2023

image

we are so back, perfect!

@yangwao yangwao merged commit 80509de into main May 25, 2023
@yangwao yangwao deleted the fix/readd-dot branch May 25, 2023 10:56
This was referenced May 25, 2023
@preschian
Copy link
Member Author

image

we are so back, perfect!

that balance tho 😮

@roiLeo
Copy link
Contributor

roiLeo commented May 25, 2023

weird flex but ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add showing DOT balances to sidebar
6 participants