Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ add statemine to teleport bridge #6152

Merged
merged 20 commits into from
Jun 16, 2023
Merged

⚡ add statemine to teleport bridge #6152

merged 20 commits into from
Jun 16, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Jun 1, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at c2d0105

This pull request enables cross-chain asset teleportation between Kusama and Statemine using the identity store. It refactors the Teleport.vue component and adds new types and functions to the teleport.ts and chains.ts files.

🤖 Generated by Copilot at c2d0105

To teleport assets with ease
We refactored the Teleport.vue piece
We used the identity store
And simplified the core
And added chainPrefixesMap for each Prefix

Leftovers

  • make balance in teleport page reactive (i.e should change after sending token is done)

@kodabot
Copy link
Collaborator

kodabot commented Jun 1, 2023

SUCCESS @daiagi PR for issue #6024 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a41ea66
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/648bc70f4cb0610008f3abf4
😎 Deploy Preview https://deploy-preview-6152--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 1, 2023

AI-Generated Summary: This pull request includes changes to support Statemine chain in the teleport bridge feature. It adds a new Chain enumeration value for STATEMINE, modifies the chainToPrefixMap to include this new chain, and introduces a new TeleprtType enumeration that helps to identify the type of teleport operation. The changes affect the Teleport.vue component, chains.ts, and teleport.ts files. Various improvements have also been made in the code, such as refactoring and removing unused functions.

@reviewpad reviewpad bot added the medium Pull request is medium label Jun 1, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Jun 1, 2023

All these work:

Kusama -> Statemine
Statemine -> Kusama
Statemine -> Basilisk
Basilisk -> Kusama
Basilisk -> Statemine

What doesn't work

Kusama / Statemine -> Basilisk

On top of that

  • make the balance in teleport page reactive

@daiagi daiagi changed the title ⚡ add statmine to telport bridge ⚡ add statmine to teleport bridge Jun 1, 2023
@daiagi daiagi changed the title ⚡ add statmine to teleport bridge ⚡ add statemine to teleport bridge Jun 1, 2023
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move teleport to _prefix/teleport

@daiagi
Copy link
Contributor Author

daiagi commented Jun 1, 2023

please move teleport to _prefix/teleport

Done

@daiagi daiagi requested a review from vikiival June 1, 2023 18:48
@daiagi
Copy link
Contributor Author

daiagi commented Jun 2, 2023

along the way, PR to fix issue in Paraspell when teleporting from Kusama to Basilisk:

@daiagi daiagi marked this pull request as ready for review June 2, 2023 21:17
@daiagi daiagi requested a review from a team as a code owner June 2, 2023 21:17
@daiagi daiagi requested review from roiLeo and removed request for a team June 2, 2023 21:17
@daiagi
Copy link
Contributor Author

daiagi commented Jun 2, 2023

Ready to review but...
Attempt to send to Basilisk causes bug in paraspell
I've already submitted pr to close that (see comment above)

Until it get merged we can disable to Basilisk tab

@daiagi
Copy link
Contributor Author

daiagi commented Jun 9, 2023

Yep. I obviously didn't test thoroughly enough.
Thanks @prury

Ill get it fixed

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sooo let's go?

@daiagi
Copy link
Contributor Author

daiagi commented Jun 14, 2023

sooo let's go?

been on the road, still jet lagged, i'll finish this one off tommorow

@yangwao
Copy link
Member

yangwao commented Jun 14, 2023

still jet lagged

https://www.garmin.com/en-US/garmin-technology/health-science/jet-lag-adviser/

https://www.youtube.com/watch?v=pY4Hkih6E1E

haven't tried it but have it! I would just travel to Asia to test this feature tbh.

@daiagi daiagi requested a review from vikiival June 15, 2023 01:07
@daiagi
Copy link
Contributor Author

daiagi commented Jun 15, 2023

@prury please check again. should be good to go

@prury
Copy link
Member

prury commented Jun 15, 2023

@prury please check again. should be good to go

works fine! ty!

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jun 15, 2023
@yangwao
Copy link
Member

yangwao commented Jun 15, 2023

pay 50 usd

merge me @daiagi

@yangwao
Copy link
Member

yangwao commented Jun 15, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.32 USD/DOT ~ 11.574 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x533a95b16fa4e71b6fd30b027d158e565e9777d4bc9a86246ab8ea7234768ade

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 15, 2023
@daiagi daiagi enabled auto-merge June 16, 2023 00:45
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Jun 16, 2023
@reviewpad reviewpad bot added medium Pull request is medium and removed large Pull request is large labels Jun 16, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 16, 2023

Code Climate has analyzed commit a41ea66 and detected 0 issues on this pull request.

View more on Code Climate.

@daiagi daiagi merged commit a7ed859 into main Jun 16, 2023
@daiagi daiagi deleted the Teleport-KSM-to-Statemine branch June 16, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teleport KSM to Statemine
8 participants