Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring back schedule #6174

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

related with #6163 (comment)

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 6, 2023 11:58
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team June 6, 2023 11:58
@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit bebfe20
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/648734d5ec06ef0008c1831d
😎 Deploy Preview https://deploy-preview-6174--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 6, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

AI-Generated Summary: This pull request fixes an issue by bringing back the 'UnlockableSchedule' component in the 'UnlockableContainer.vue' file. It includes uncommenting the component import and usage in the template.

@vikiival
Copy link
Member

vikiival commented Jun 8, 2023

Sir but that component does not work right?

@Jarsen136
Copy link
Contributor Author

Sir but that component does not work right?

There is no api for this schedule for now, so we could change the config manually to make it display correct date and phase.

@vikiival
Copy link
Member

There wont be any yet.
Every phase starts fron 9am ends 11pm and lasts for hours/mints are gone

@codeclimate
Copy link

codeclimate bot commented Jun 12, 2023

Code Climate has analyzed commit bebfe20 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

There wont be any yet. Every phase starts fron 9am ends 11pm and lasts for hours/mints are gone

How about now?

image

@yangwao
Copy link
Member

yangwao commented Jun 14, 2023

How about now?

we will be remaking this for v1 anyway, merging for now

@yangwao yangwao merged commit f648630 into kodadot:main Jun 14, 2023
This was referenced Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants