Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix simple mint e2e #6209

Merged
merged 2 commits into from
Jun 13, 2023
Merged

test: fix simple mint e2e #6209

merged 2 commits into from
Jun 13, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Jun 13, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • fix e2e test for simple-mint

Copilot Summary

🤖 Generated by Copilot at 9782d41

Fixed a bug in the e2e test for simple minting of NFTs. Changed the selector for the name input to target the input element directly.

🤖 Generated by Copilot at 9782d41

cy.get selector
changed to fix input bug
minting NFTs - spring

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9782d41
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6487fc983602a100084513b2
😎 Deploy Preview https://deploy-preview-6209--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 13, 2023

AI-Generated Summary: This pull request updates the Cypress test for simple mint in rmrk by modifying how the input selectors for the 'name' and 'symbol' fields are targeted. The changes make sure the 'input' elements within the '[data-cy]' attributes are selected, providing more accurate targeting for the tests.

@reviewpad reviewpad bot added the small Pull request is small label Jun 13, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 13, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Jun 13, 2023

Code Climate has analyzed commit 9782d41 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian changed the title Test/fix-simple-mint-test test: fix simple mint e2e Jun 13, 2023
@preschian preschian marked this pull request as ready for review June 13, 2023 05:35
@preschian preschian requested a review from a team as a code owner June 13, 2023 05:35
@preschian preschian requested review from daiagi and Jarsen136 and removed request for a team June 13, 2023 05:35
@preschian preschian enabled auto-merge June 13, 2023 05:35
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HELLOWORLDASDF

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 13, 2023
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@preschian preschian merged commit 2853b0c into main Jun 13, 2023
@preschian preschian deleted the test/fix-simple-mint-test branch June 13, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants