Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 notification icon regular #6212

Merged
merged 2 commits into from
Jun 13, 2023
Merged

🔧 notification icon regular #6212

merged 2 commits into from
Jun 13, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 13, 2023 •
edited
Loading

@roiLeo roiLeo requested a review from a team as a code owner June 13, 2023 14:53
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team June 13, 2023 14:53
@netlify
Copy link

netlify bot commented Jun 13, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c335e1a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/648885d17c4b78000955bd9a
😎 Deploy Preview https://deploy-preview-6212--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 13, 2023

AI-Generated Summary: This pull request updates the notification icon in the NotificationBoxButton.vue file by changing the NeoIcon component to use the regular version of the bell icon from the FontAwesome package.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 13, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 13, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo enabled auto-merge June 13, 2023 14:54
@prury
Copy link
Member

prury commented Jun 13, 2023 •
edited
Loading

@roiLeo the icon looks fine but the dialog wont open

13.06.2023_12.04.22_REC.mp4

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 13, 2023

@roiLeo the icon looks fine but the dialog wont open

fixed ✅

inanimate-insanity-ii

@codeclimate
Copy link

codeclimate bot commented Jun 13, 2023

Code Climate has analyzed commit c335e1a and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 13, 2023
@vikiival vikiival merged commit 3c79f64 into kodadot:main Jun 13, 2023
@roiLeo roiLeo deleted the hotfix/notification/icon branch June 14, 2023 06:50
This was referenced Jun 15, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roiLeo @prury @vikiival