Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Success notification unlockable drop #6213

Merged
merged 8 commits into from
Jun 14, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jun 13, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image image

Copilot Summary

🤖 Generated by Copilot at 2f58564

Added a new UnlockableLoader component to improve the user experience when minting and viewing unlockable NFTs. Replaced the old Loader component with the new one in the UnlockableContainer component. Used some components and hooks from the @kodadot1/brick library.

🤖 Generated by Copilot at 2f58564

To mint NFTs with a flair
We added a new UnlockableLoader there
It uses some hooks and props
And some Neo components on top
And shows a congrats message with care

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 13, 2023 17:24
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team June 13, 2023 17:24
@kodabot
Copy link
Collaborator

kodabot commented Jun 13, 2023

SUCCESS @Jarsen136 PR for issue #6204 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit cdff8b3
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6489d71568db1200080f94fb
😎 Deploy Preview https://deploy-preview-6213--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 13, 2023

AI-Generated Summary: This pull request introduces a new feature for displaying a success notification when an unlockable drop is minted. It adds a new component called UnlockableLoader.vue and makes minor modifications to the UnlockableContainer.vue component. The success notification is shown for 30 seconds after minting and includes a "View Item" button.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jun 13, 2023
@exezbcz
Copy link
Member

exezbcz commented Jun 13, 2023

Great work! Is there a way to activate the popup without minting the NFT? Could you guide me to a resource where I can find more information on this? Thanks!

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jun 14, 2023

Great work! Is there a way to activate the popup without minting the NFT? Could you guide me to a resource where I can find more information on this? Thanks!

Yes, I have made a preview env for testing. Opening the page with parms ?redesign=true, the popup would be active auto and then the button would be changed after a few seconds.
https://deploy-preview-6213--koda-canary.netlify.app/stmn/unlockable?redesign=true

I will remove this testing logic before the PR is about to merge.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text look a bit small on figma

Why don't we unify component between these two

Capture d’écran 2023-06-14 à 8 41 39 AM Capture d’écran 2023-06-14 à 8 41 29 AM

components/collection/unlockable/UnlockableLoader.vue Outdated Show resolved Hide resolved
@exezbcz
Copy link
Member

exezbcz commented Jun 14, 2023

@roiLeo its a different success, the one for drop page is in figma drop page

edit: Yeah, I will make some changes

@yangwao
Copy link
Member

yangwao commented Jun 14, 2023

merging?

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in anticipation of a unified design, let's roll

@exezbcz
Copy link
Member

exezbcz commented Jun 14, 2023

Okay, sorry for changing it now. Let's make the text 16px
image

Ad @roiLeo We plan to implement a unified design that includes redesigned notification toasts. It seems that this style will be used for most of our notifications.

@Jarsen136
Copy link
Contributor Author

Okay, sorry for changing it now. Let's make the text 16px

✅ Updated

image

@exezbcz
Copy link
Member

exezbcz commented Jun 14, 2023

okay, a few minor changes

  • make the background the same as with opening the wallet connect sidebar - if its already, my bad :D
  • The button should be 16px font size
  • make the box close only with the close icon because otherwise, it could happen you accidentally close it.

Thanks!

image

Maybe + change the copy a bit and add that it will be visible in the 30s on your profile, for people that closed the dialog :D

@codeclimate
Copy link

codeclimate bot commented Jun 14, 2023

Code Climate has analyzed commit cdff8b3 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

okay, a few minor changes

  • make the background the same as with opening the wallet connect sidebar - if its already, my bad :D
  • make the box close only with the close icon because otherwise, it could happen you accidentally close it.

It's already there.

  • The button should be 16px font size
    Maybe + change the copy a bit and add that it will be visible in the 30s on your profile, for people that closed the dialog :D

✅ Updated

image

@exezbcz
Copy link
Member

exezbcz commented Jun 14, 2023

It's already there.

Cool, I think I will create one more issue for some small things, I don't want to hold up this one. Thanks!

visual oki 🏁

@yangwao
Copy link
Member

yangwao commented Jun 14, 2023

pay 30 usd

@yangwao yangwao merged commit 93cd9ed into kodadot:main Jun 14, 2023
@yangwao
Copy link
Member

yangwao commented Jun 14, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.74 USD/DOT ~ 6.329 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x84c23fa2b4fd20e12a49840de308b4091c5f695e6dfe94c0cd65a186e633b6a6

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-visual-ok-✅ waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Success notification unlockable drop
6 participants