Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 NeoButton icon pack #6218

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 14, 2023

Capture d’écran 2023-06-14 à 1 52 57 PM

Same as #6170 but for NeoButton component

⚠️ some buttons might have icon changed, ping me if you see something strange

@roiLeo roiLeo requested a review from a team as a code owner June 14, 2023 11:59
@roiLeo roiLeo requested review from preschian and vikiival and removed request for a team June 14, 2023 11:59
@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2c60b04
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6489ab8a46003d0007d7ae53
😎 Deploy Preview https://deploy-preview-6218--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 14, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 14, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Jun 14, 2023

Code Climate has analyzed commit 2c60b04 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 14, 2023

AI-Generated Summary: This pull request updates the SubmitButton.vue and NeoButton.vue components. It adds an icon-pack attribute with a default value of 'far' to the SubmitButton.vue component and modifies the default value of icon-pack in NeoButton.vue to 'fas'. Additionally, it includes minor refactoring of the props definition in both components.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 15, 2023
@vikiival vikiival merged commit ce5ab40 into kodadot:main Jun 18, 2023
@roiLeo roiLeo deleted the hotfix/NeoButton/iconPack branch June 18, 2023 11:06
This was referenced Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants