Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rearrange smart portfolio view #6230

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jun 15, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 68196f3

Improved the UI and code quality of the balance table component. Used the ChainToken type from the identity store module in MultipleBalances.vue and exported it for reuse.

🤖 Generated by Copilot at 68196f3

ChainToken shared
Balance table refined
Autumn of clean code

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 15, 2023 05:19
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team June 15, 2023 05:19
@kodabot
Copy link
Collaborator

kodabot commented Jun 15, 2023

SUCCESS @Jarsen136 PR for issue #6222 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 804d335
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/648b384102075c0008076e21
😎 Deploy Preview https://deploy-preview-6230--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 15, 2023

AI-Generated Summary: This pull request includes a patch that primarily fixes and rearranges the smart portfolio view by modifying two files: components/balance/MultipleBalances.vue and stores/identity.ts. The changes consist of introducing a filter function to remove empty balance chains, updating display elements, and reordering elements within the balance rows. Additionally, the ChainToken type from stores/identity.ts has been exported. In total, the patch consists of 25 insertions and 9 deletions.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 15, 2023
@preschian
Copy link
Member

@exezbcz wondering, how about empty states? in case the user doesnt have balance in any chains yet

image

@yangwao
Copy link
Member

yangwao commented Jun 15, 2023

how about empty states?

let's put there placeholder text

"You've got zero balance on this address across chains we are monitoring. If you want to buy small amount of crypto, click on Add funds through our verified on-ramp partner."

@Jarsen136
Copy link
Contributor Author

how about empty states?

let's put there placeholder text

"You've got zero balance on this address across chains we are monitoring. If you want to buy small amount of crypto, click on Add funds through our verified on-ramp partner."

✅ Done
image

@yangwao
Copy link
Member

yangwao commented Jun 15, 2023

Some merge conflict and we can merge!

@Jarsen136
Copy link
Contributor Author

Some merge conflict and we can merge!

conflict solved.

@exezbcz
Copy link
Member

exezbcz commented Jun 15, 2023

Hey hey, I think we can tweek the spacing of the columns a bit
image

statemine is the longest word now, I think we can move the token column closer to that
image

  • it would be also nice to have all the items aligned in the column

"You've got zero balance on this address across chains we are monitoring. If you want to buy small amount of crypto, click on Add funds through our verified on-ramp partner."

  • its pretty long, but I guess good for now, I will come up with something shorter

@codeclimate
Copy link

codeclimate bot commented Jun 15, 2023

Code Climate has analyzed commit 804d335 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

Hey hey, I think we can tweek the spacing of the columns a bit image

statemine is the longest word now, I think we can move the token column closer to that image

  • it would be also nice to have all the items aligned in the column

It should be fixed now.

@exezbcz
Copy link
Member

exezbcz commented Jun 15, 2023

nice job!

@yangwao
Copy link
Member

yangwao commented Jun 15, 2023

pay 30 usd

@yangwao yangwao merged commit 71073b7 into kodadot:main Jun 15, 2023
@yangwao
Copy link
Member

yangwao commented Jun 15, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.32 USD/DOT ~ 6.944 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xc8ac469adead1df9a29373c6ccc97af8b4cf1d2ba20a0f61a8cb71b1a0859fd4

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 15, 2023
This was referenced Jun 15, 2023
This was referenced Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rearrange smart portfolio view
5 participants