Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drop image examples and carousel #6323

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jun 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at a9dfde4

This pull request improves the image slider component for the unlockable campaign feature, by adding a looping feature, a text message, and custom styling. It also refactors some code, fixes some bugs, and adds some localization and constants. The main files affected are ImageSlider.vue, UnlockableContainer.vue, const.ts, en.json, and some style files.

🤖 Generated by Copilot at a9dfde4

Sing, O Muse, of the skillful coder who enhanced the image slider
With looping feature, text message, and custom styling for the arrows
He fetched and displayed the latest waifu images, DISPLAY_SLIDE_IMAGE_COUNT
And added the mint.unlockable.imageTip to the en.json file

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 24, 2023 08:56
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team June 24, 2023 08:56
@kodabot
Copy link
Collaborator

kodabot commented Jun 24, 2023

WARNING @Jarsen136 PR for issue #6280 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6280

@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e9aa60e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/649721816963c40008f161d0
😎 Deploy Preview https://deploy-preview-6323--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 24, 2023

AI-Generated Summary: This pull request introduces changes to drop image examples and enhance the carousel feature in the ImageSlider.vue and UnlockableContainer.vue components. It also adds necessary data and styles to const.ts, en.json, _carousel-arrows.scss, and global.scss files. The patch includes 58 new insertions and 13 deletions across 6 files.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 24, 2023
@exezbcz
Copy link
Member

exezbcz commented Jun 24, 2023

looking good!

one thing to the carousel:

  • it wont basically be a carousel, the images wont move, only 4 imgs total

limit the imgs displayed to only 4 and make it an infinite carousel

sorry for the confusion with an infinite one.

@prury
Copy link
Member

prury commented Jun 24, 2023

@exezbcz is mobile ok to you or it should be aligned to the left?
image

@exezbcz
Copy link
Member

exezbcz commented Jun 24, 2023

@prury yeah, the copy that indicates that the preview is only one of many possible drops should not be 2 row

  • then the preview on mobile should also be square - not changing the ar of 1:1

To reply to your original message: I don't really care :D Up to @Jarsen136 what he likes better

image

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked S-changes-requested-🤞 PR is almost good to go, just some fine tunning and removed S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Jun 24, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 24, 2023

Code Climate has analyzed commit e9aa60e and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

I have made some updates according to the above comments. Pls check it. @exezbcz @prury
image

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jun 24, 2023
@exezbcz
Copy link
Member

exezbcz commented Jun 24, 2023

nice job! thanks

@vikiival vikiival merged commit fac292d into kodadot:main Jun 26, 2023
This was referenced Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop image examples and carousel
6 participants