-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Drops pages could have dedicated og:image #6363
Conversation
Jarsen136
commented
Jun 29, 2023
•
edited
Loading
edited
- Closes Drops pages could have dedicated og:image #6349
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request addresses a bug where drop pages were not having their dedicated open graph images (og:image). It introduces several changes across multiple files to resolve this. In 'DropContainer.vue', 'UnlockableCollectionBanner.vue', and 'UnlockableContainer.vue', the open graph meta tags have been updated with the correct description and image sources. The files also have additional imports for 'unlockableDesc' and 'convertMarkdownToText' from the utils. In 'DropContainer.vue', the 'handleSubmitMint' function's 'createUnlockableMetadata' call has been updated to include a description. In 'UnlockableContainer.vue', similar changes as 'DropContainer.vue' are applied. The 'handleSubmitMint' function now submits an image and a description for creating the unlockable metadata. Lastly, in 'utils.ts', the function 'createUnlockableMetadata' has been modified to have two parameters, 'imageHash' and 'description'. Overall, these changes should provide a dedicated og:image meta tag for each drop page, enhancing the website's SEO. |
Emm. I still do not figure out why it does not work, as the seo tag had been updated accordingly. link: https://deploy-preview-6363--koda-canary.netlify.app/stmn/drops/free-drop The preview information is still the same as the previous one. |
/drops shows the image correctly as Jarsen said, the right description for the drop link still won't show opengraph tags, if it helps:
|
maybe something related with kodadot workers? ssr-opengraph? |
seems like prerendering on netlify is not working. I can help with canary/beta by using worker I will open the PR on the workers side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjust e2e test? otherwise lgtm 👍
Code Climate has analyzed commit 999937a and detected 0 issues on this pull request. View more on Code Climate. |
✅ E2E test pass |
|