-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 vue3 composition api pages #6379
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request primarily revolves around the refactoring of Vue.js components in order to utilize Vue 3's Composition API. It involves modifications in the 'activity.vue' and 'items.vue' files located inside the '/pages/_prefix' directory. These changes involved removing the previous usage of Vue Class components syntax, replacing them with the Composition API's syntax to improve readability and maintainability of the code base. Furthermore, one test case in 'media.cy.ts' was updated to remove a query parameter from the visit URL, implying a move away from dynamic testing based on this parameter. Finally, the mixin 'experimentMixin.ts' was removed, signaling that the functionality it provided (deciding whether to test a redesigned version of the site) has been deprecated or replaced elsewhere in the code. Overall, this suggests a shift towards consolidating functionality and making the code more direct and modern, following best practices for using Vue 3. The use of Composition API provides better re-usability, organization, and understanding of the code by developers. As with all refactors, proper testing is advised to ensure all functionalities work as expected after the modifications. |
Reviewpad Report
|
Code Climate has analyzed commit 331efd7 and detected 0 issues on this pull request. View more on Code Climate. |
Looks good sir |
did not find any strange behavior or different console warnings compared to canary on those pages |
As suggested by @roiLeo, i'm testing share preview on the modified pages Problems encountered so far(telegram, discord):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I've made some test and it's not related with this PR, preview doesn't work for url starting with |
Good to know! thank you |
part of #4750
/:prefix/collection/:id/activity
page/:prefix/explore/items
page/:prefix/explore/collectibles
page/identity
page/sustainibility
pageedit: DRAFT doesn't work yet