Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 most advanced code #6396

Merged
merged 2 commits into from
Jul 5, 2023
Merged

🎨 most advanced code #6396

merged 2 commits into from
Jul 5, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Jul 5, 2023

No description provided.

@vikiival vikiival requested a review from a team as a code owner July 5, 2023 15:11
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team July 5, 2023 15:11
@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5766b51
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64a5b447fd62140008980e87
😎 Deploy Preview https://deploy-preview-6396--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 5, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 5, 2023

AI-Generated Summary: This pull request contains updates to the DropCard.vue and useDrops.ts files within the 'drops' component.

The changes to DropCard.vue include the replacement of a nuxt-link with a more flexible component which, depending on whether an external URL is present, utilizes either an anchor (a) tag or a nuxt-link. It also implements a new reference externalUrl and adjusts rendering conditions.

In the useDrops.ts file, the definition and management of 'future drops' is modified. A predefined dummyDrop object is introduced that represents an example drop, and logic is included to add this dummyDrop to the future drops array if a client name is not present.

In summary, this pull request improves the flexibility and functionality of the 'drops' component. It also provides a mock future-drop instance for scenarios where an actual client name is not provided.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Image dose not load. Otherwise looks nice.

components/drops/DropCard.vue Outdated Show resolved Hide resolved
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@codeclimate
Copy link

codeclimate bot commented Jul 5, 2023

Code Climate has analyzed commit 5766b51 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member Author

vikiival commented Jul 5, 2023

Image dose not load. Otherwise looks nice.

That is the image ;D

nftstorage.link/ipfs/bafkreidvb2my5vj6jgpbrwa7dfw55tryhfk7um5inuxnz7y7khqse2thjq

@vikiival vikiival linked an issue Jul 5, 2023 that may be closed by this pull request
@yangwao
Copy link
Member

yangwao commented Jul 5, 2023

uh, okay let's goo we will make design for that
cc @exezbcz

@yangwao yangwao merged commit f8cb57b into main Jul 5, 2023
15 checks passed
@yangwao yangwao deleted the 6390-another-form branch July 5, 2023 18:47
This was referenced Jul 5, 2023
@exezbcz
Copy link
Member

exezbcz commented Jul 5, 2023

@yangwao what is needed 👀

edit: Ic, the option to create drop, on it

@vikiival
Copy link
Member Author

vikiival commented Jul 6, 2023

what is needed 👀

image Image dose not load. Otherwise looks nice.

This is the current link for the form. Wao wants to make it nicer

This was referenced Jul 17, 2023
This was referenced Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make me Shanghai Waifu Drop
4 participants