Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 overlapping modal #6407

Merged
merged 7 commits into from
Jul 14, 2023
Merged

🔧 overlapping modal #6407

merged 7 commits into from
Jul 14, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 6, 2023 •
edited
Loading

@roiLeo roiLeo requested a review from a team as a code owner July 6, 2023 12:33
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team July 6, 2023 12:33
@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9d7ee34
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64abf7af6e5b6e0007cdfc48
😎 Deploy Preview https://deploy-preview-6407--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 6, 2023

AI-Generated Summary: This pull request refactors the Navbar component. It changes the navbar from a b-navbar to a custom nav element. Existing functional attributes have been moved to the appropriate new elements. It enhances the navbar responsiveness and accessibility by adding new properties, such as role, aria-label, aria-hidden, etc. A new feature for toggling mobile navigation menu has been added. It also includes modifications in other associated components like CreateDropdown, MobileLanguageOption, NavbarExploreOptions, NotificationBoxButton and ProfileDropdown to improve user interaction on mobile and ensure all modals close when opening another one. Some structural changes also include replacing b-navbar-item with nuxt-link or div elements. Changes also affect the way in which NevbarExpandableSection is used. Overall, these changes aim to improve the navbar's structure, functionality and user experience, especially for mobile users.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jul 6, 2023
@roiLeo roiLeo mentioned this pull request Jul 6, 2023
Closed
@Jarsen136
Copy link
Contributor

I found a bug bring from these change. I clicked the avatar several times on the navbar, but the modal would not close.
Kapture 2023-07-06 at 23 38 11

@reviewpad reviewpad bot added small Pull request is small and removed large Pull request is large labels Jul 7, 2023
@prury
Copy link
Member

prury commented Jul 7, 2023 •
edited
Loading

notifications and wallet sidebar are not overlapping anymore, but their behavior are still odd( it was strange on beta already as well)
try clicking on them in this order: refresh the page -> notifications -> profile rounded button -> notifications

@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 10, 2023

try clicking on them in this order: refresh the page -> notifications -> profile rounded button -> notifications

thank you for these reproduction steps, I made a change that wasn't pretty but it should work now

@exezbcz
Copy link
Member

exezbcz commented Jul 10, 2023

woho, thank you @roiLeo! We are now officially ready for the cart :D

@prury
Copy link
Member

prury commented Jul 10, 2023

transitioning between them works fine now!
be wary of #6413

@roiLeo roiLeo mentioned this pull request Jul 10, 2023
Closed
1 task
Jarsen136
Jarsen136 reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

components/navbar/ProfileDropdown.vue Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jul 10, 2023

Code Climate has analyzed commit 9d7ee34 and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 10, 2023
@vikiival vikiival merged commit 9209022 into kodadot:main Jul 14, 2023
15 checks passed
@vikiival
Copy link
Member

pay 40 usd

This was referenced Jul 17, 2023
Merged
Merged
This was referenced Jul 25, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overlapping profile modal on mobile Sidebars open over each other
6 participants
@roiLeo @Jarsen136 @prury @exezbcz @vikiival @preschian