Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➖ unused utils #6443

Merged
merged 4 commits into from
Jul 20, 2023
Merged

➖ unused utils #6443

merged 4 commits into from
Jul 20, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 19, 2023

No description provided.

@roiLeo roiLeo added the A-refactoring Refactoring stuff, make code more readable, mitigating tech debt label Jul 19, 2023
@roiLeo roiLeo requested a review from a team as a code owner July 19, 2023 15:07
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team July 19, 2023 15:07
@netlify
Copy link

netlify bot commented Jul 19, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 307574d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64b9178fb4d25a0008c52e4c
😎 Deploy Preview https://deploy-preview-6443--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 19, 2023

AI-Generated Summary: This pull request involves the removal of a large number of redundant or unused utility files in the project. It includes the deletion of 14 files, resulting in a total of 526 line deletions. Notable deletions include urlTransform.spec.ts, various utility function files like chainProperties.ts, proxy.ts, and rpc.ts. Test files have also been deleted. This clean-up contributes to a more streamlined codebase by eliminating unnecessary files and functions. The developer, roiLeo, has applied these changes.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jul 19, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 19, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@Jarsen136
Copy link
Contributor

build failed
image

@codeclimate
Copy link

codeclimate bot commented Jul 20, 2023

Code Climate has analyzed commit 36b2b0d and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival mentioned this pull request Jul 20, 2023
Open
@vikiival
Copy link
Member

vikiival
vikiival approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo is getting fit for summer

utils/vueNotification.ts Show resolved Hide resolved
@vikiival
Copy link
Member

pay 15 usd

@vikiival vikiival merged commit 819a9e8 into kodadot:main Jul 20, 2023
10 checks passed
@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 20, 2023

Repo is getting fit for summer

yes-zyzz

This was referenced Jul 25, 2023
Merged
Merged
Merged
Merged
This was referenced Aug 2, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt large Pull request is large waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roiLeo @Jarsen136 @vikiival