Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Teleport bridge is showing incorrect balances #6446

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jul 20, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;
    /rmrk/teleport
CleanShot 2023-07-20 at 10 02 13@2x

Copilot Summary

🤖 Generated by Copilot at 219f99a

Improved KSM balance display in Teleport.vue component. Used nativeBalance for cross-chain compatibility and simplified balance calculation.

🤖 Generated by Copilot at 219f99a

To show KSM balance with ease
We updated chainBalances keys
We used nativeBalance
And simplified balance
To make it consistent across chains, please

@hassnian hassnian requested a review from a team as a code owner July 20, 2023 05:12
@hassnian hassnian requested review from roiLeo and daiagi and removed request for a team July 20, 2023 05:12
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 219f99a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64b8c23bd4b934000941ca62
😎 Deploy Preview https://deploy-preview-6446--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jul 20, 2023

SUCCESS @hassnian PR for issue #6433 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 20, 2023

AI-Generated Summary: This pull request introduces changes to the 'Teleport.vue' file in the 'teleport' component to fix incorrect balance issues. The changes involve using the 'nativeBalance' property instead of the 'balance' property for multiBalances of several chains including KUSAMA, BASILISK, and STATEMINE. Also, a modification in the 'myKsmBalance' computed property is noted where the returned balance value is no longer multiplied by 'ksmTokenDecimals.value'. The patch includes 6 insertions and 4 deletions.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 20, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 20, 2023

Code Climate has analyzed commit 219f99a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 20, 2023
@prury
Copy link
Member

prury commented Jul 20, 2023

Welcome!
i was not able to reproduce the error, but seems to be working fine for me.
tried multiple accounts, two different wallets, 2 browsers

@helloitsdamsky could you check using https://deploy-preview-6446--koda-canary.netlify.app and tell us if it is fixed for you?

@vikiival
Copy link
Member

Pinged Damsky through DM

@damskyftw
Copy link
Member

damskyftw commented Jul 21, 2023

Welcome! i was not able to reproduce the error, but seems to be working fine for me. tried multiple accounts, two different wallets, 2 browsers

@helloitsdamsky could you check using https://deploy-preview-6446--koda-canary.netlify.app and tell us if it is fixed for you?

everything seems fine! Only.. in one instance we are using , and in other instance we are using .

I’d like to see it consistent, using DOT (.) e.g. 6.9755

image

@vikiival
Copy link
Member

everything seems fine! Only.. in one instance we are using , and in other instance we are using .

That's more how component handles it vs how we handle displaying currencies

@vikiival vikiival merged commit 7492f6b into kodadot:main Jul 21, 2023
16 checks passed
@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Jul 21, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.48 USD/DOT ~ 3.65 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x934a36ff6370e02e19ac2edbc188af29ed0c1ccf0f71d222d8516a8dd04f6ec1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 21, 2023
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 21, 2023
This was referenced Jul 25, 2023
This was referenced Aug 2, 2023
@hassnian hassnian deleted the issue-6433 branch August 7, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teleport bridge is showing incorrect balances
8 participants