Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce-using-nuxt-property-decorator #6450

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Jul 21, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Pages in this PR

  1. /hot
  2. /sales
  3. /series-insight
  4. error

desired outcome

no change in look and/or behavior

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 2a2d804

This pull request refactors several Vue components to use the Composition API and the script setup syntax, which are modern and recommended features of Vue 3. These changes improve the code quality, readability, and performance of the components. The pull request also removes some unused or redundant code and imports. The affected components are SeriesTable.vue, hot.vue, sales.vue, series-insight.vue, and error.vue.

🤖 Generated by Copilot at 2a2d804

We're breaking free from the old ways
We're using the script setup and the Composition API
We're refactoring our components to make them shine
We're the masters of Vue and we're ready to rock

@daiagi daiagi requested a review from a team as a code owner July 21, 2023 08:30
@daiagi daiagi requested review from roiLeo and Jarsen136 and removed request for a team July 21, 2023 08:30
@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2a2d804
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ba4237c0a9780008ff8943
😎 Deploy Preview https://deploy-preview-6450--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 21, 2023

AI-Generated Summary: This pull request includes multiple patches addressing different aspects of the code base. The first patch modifies the "error.vue" by simplifying the import statement and refactoring the script setup. The second patch updates the "hot.vue" and "sales.vue" pages by modifying how components are exported and simplifying some of the code. The third patch includes significant expansions of the sales page. The fourth patch is a simplification of the sales page, removing some commented out code blocks. The fifth patch involves an extensive rework of the "SeriesTable.vue" module, implementing async imports and using reactive statements instead of mixins. The final patch modifies the "series-insight.vue" page, utilising the Vue 3 Composition API for setup as well as modifying the head element. With this combination of patches, the PR seems to be moving the code base towards a more modern and simplified usage of Vue/Nuxt and making improvements to the series table implementation.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jul 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Jul 21, 2023

Code Climate has analyzed commit 2a2d804 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's gooooooooo 🚀

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 21, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Jul 21, 2023

let's gooooooooo rocket

Wow @roiLeo
talk about fast 🚀

@vikiival vikiival merged commit c536f0b into main Jul 21, 2023
16 checks passed
@vikiival vikiival deleted the Reduce-using-nuxt-property-decorator branch July 21, 2023 12:05
This was referenced Jul 25, 2023
This was referenced Aug 2, 2023
@roiLeo roiLeo mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants