-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 vue 3 composition create pages #6453
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request features a refactoring of the Vue.js project structure. In general, there are alterations in the Firstly, within In the files under the Also, a mix-in file Overall, these changes seem to provide more maintainable and readable code that aligns with Vue 3's composition design patterns. |
Reviewpad Report
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
Code Climate has analyzed commit 99241f2 and detected 0 issues on this pull request. View more on Code Climate. |
RMRK2 RMRK1 BSX SNEK STMN will be updating as i go |
Hello, just so you know I didn't change anything related to minting process. |
oh, thank you, will redirect my testing then
|
Looks oki, |
@roiLeo those RMRK redirections were already not working on beta tho |
Wait does the redirection work for you? When I tested it on my side it was working as excepted (tab relates with URL path) |
Oh, i got it now, yes , the tab redirection works properly for all of them. When testing i was testing both the tab redirection and the automatic redirection that happens after i mint something (this is what is not working) I may have got confused because i saw a timeout function |
Alright I'll be checking this next week |
Thank you for clarifying it for me |
/massmint
pageedit:
massmint tabs doesn't work on beta