Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource.meta null check #6485

Merged
merged 1 commit into from
Jul 29, 2023
Merged

resource.meta null check #6485

merged 1 commit into from
Jul 29, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Jul 29, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

encountered this bug while working on shopping cart

Did your issue had any of the "$" label on it?

image

while working on shopping cart encountered null check bug
@daiagi daiagi requested a review from a team as a code owner July 29, 2023 04:36
@daiagi daiagi requested review from preschian and vikiival and removed request for a team July 29, 2023 04:36
@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f93a927
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64c497651343b00008fb4c4b
😎 Deploy Preview https://deploy-preview-6485--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 29, 2023

AI-Generated Summary: This pull request introduces a null check in the useGalleryItem function in useGalleryItem.ts file. Previously, the code was trying to access properties of resource.meta without checking if resource.meta was non-null, which could lead to a null reference error. This commit adds additional safety by using the optional chaining operator (?.) to ensure resource.meta is not null before trying to access its properties. This change was made in response to a null check bug the developer encountered while working on the shopping cart.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 29, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 29, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Jul 29, 2023

Code Climate has analyzed commit f93a927 and detected 0 issues on this pull request.

View more on Code Climate.

@daiagi daiagi requested review from roiLeo and removed request for vikiival July 29, 2023 04:38
@yangwao
Copy link
Member

yangwao commented Jul 29, 2023

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Jul 29, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.24 USD/DOT ~ 9.542 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x54441e8e9c139c37d782a4b43a2beaaebf102cd04a115e5c742bccfe57ded673

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 29, 2023
@vikiival vikiival merged commit e0f8cfe into main Jul 29, 2023
15 checks passed
@vikiival vikiival deleted the fix/null-bug-in-galleryItem branch July 29, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants