Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop page announcement on landing #6497

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jul 30, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 9bad4bc

Refactored UnlockableLandingTag component to improve responsiveness and added translation key for smaller screens.

🤖 Generated by Copilot at 9bad4bc

UnlockableLandingTag
Refactored for small screens
A fresh mint in spring

@Jarsen136 Jarsen136 requested a review from a team as a code owner July 30, 2023 14:04
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team July 30, 2023 14:04
@kodabot
Copy link
Collaborator

kodabot commented Jul 30, 2023

SUCCESS @Jarsen136 PR for issue #6490 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 30, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 52d3b52
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64c77d0bec5049000888915f
😎 Deploy Preview https://deploy-preview-6497--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 30, 2023

AI-Generated Summary: This pull request mainly addresses changes in the UI of the landing tag in the unlockable page. It adjusts the unlockable landing tag's CSS class based on the window size (it introduces a 'small size' condition). It also refactors the mint live text to display different text based on the window size. This is achieved by using a computed property that toggles the displayed text between 'mint.unlockable.mintLiveSmall' and 'mint.unlockable.mintLive'. A new text entry 'mintLiveSmall' is added to the English locale (en.json) file. In addition, the patch removes the use of the component NeoIcon and replaces it with a manually defined div for the separator. Other minor CSS changes are also included in this commit.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 30, 2023
@exezbcz
Copy link
Member

exezbcz commented Jul 30, 2023

nice!
can you please make the separator k-hovergrey in dark mode?

@codeclimate
Copy link

codeclimate bot commented Jul 31, 2023

Code Climate has analyzed commit 52d3b52 and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 31, 2023
@vikiival vikiival merged commit 7945714 into kodadot:main Jul 31, 2023
15 checks passed
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Jul 31, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 5.13 USD/DOT ~ 1.949 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x32c9062ee3720625ab7815c9e41282232cf13d46a96d207a0bad30ba3be03426

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop page announcement on landing
8 participants