Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tooltip inside modal style #6845

Merged
merged 7 commits into from
Aug 23, 2023
Merged

fix: tooltip inside modal style #6845

merged 7 commits into from
Aug 23, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Aug 21, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
iShot_2023-08-21_09 52 08 iShot_2023-08-21_09 52 54

Copilot Summary

🤖 Generated by Copilot at b18b253

Enhanced the user interface of the NFT transfer feature by using a custom tooltip component and fixing a styling bug. Modified the NeoTooltip component to accept a rootClass prop and updated the TransferConfirmModal component to use it.

🤖 Generated by Copilot at b18b253

NeoTooltip shines
Customizing its root class
Winter bug is fixed

@floyd-li floyd-li requested a review from a team as a code owner August 21, 2023 02:06
@floyd-li floyd-li requested review from preschian and vikiival and removed request for a team August 21, 2023 02:06
@kodabot
Copy link
Collaborator

kodabot commented Aug 21, 2023

SUCCESS @floyd-li PR for issue #6837 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 21, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7af4407
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e4ca12ae9b9b0008aa0050
😎 Deploy Preview https://deploy-preview-6845--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 21, 2023

AI-Generated Summary: This pull request addresses style issues concerning tooltips within modals. Modifications have been made in both TransferConfirmModal.vue and NeoTooltip.vue files.

In the TransferConfirmModal.vue file, the NeoIcon elements rendering circle info icons have been replaced with NeoTooltip components to provide more context information for addresses. There is a new CSS rule to allow 'parent-selector'.

For the NeoTooltip.vue a new converted property 'rootClass' is added to further expand configurations.

The refactoring aids in improving the clarity of addresses represented in the application, enhancing overall user experience. Changes have resulted in 25 insertions and 11 deletions across the two files.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 21, 2023
@vikiival
Copy link
Member

And mobile?

Jarsen136
Jarsen136 reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

components/transfer/TransferConfirmModal.vue Outdated Show resolved Hide resolved
@Jarsen136 Jarsen136 requested a review from roiLeo August 21, 2023 12:02
@prury
Copy link
Member

prury commented Aug 21, 2023

Firefox:(was not happening on canary)

image

tooltip showing faster tho

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Aug 21, 2023
@floyd-li
Copy link
Member Author

Firefox:(was not happening on canary)

image

tooltip showing faster tho

alright seem :has selector has compatibility issue with firefox. i'll try another way to solve it.
图片

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 21, 2023
Jarsen136
Jarsen136 approved these changes Aug 22, 2023
View reviewed changes
components/transfer/TransferConfirmModal.vue Outdated Show resolved Hide resolved
components/transfer/TransferConfirmModal.vue Outdated Show resolved Hide resolved
floyd-li and others added 2 commits August 22, 2023 22:45
@floyd-li @Jarsen136
Update TransferConfirmModal.vue
88a0bb6 
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@floyd-li @Jarsen136
Update TransferConfirmModal.vue
7af4407 
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 22, 2023

Code Climate has analyzed commit 7af4407 and detected 0 issues on this pull request.

View more on Code Climate.

@floyd-li
Copy link
Member Author

Firefox:(was not happening on canary)

image

tooltip showing faster tho

alright seem :has selector has compatibility issue with firefox. i'll try another way to solve it.

图片

may i have any bonus for this pr🤔

@yangwao
Copy link
Member

yangwao commented Aug 22, 2023

may i have any bonus for this pr🤔

if you want to take time, it's oke to fix it in this pr

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Aug 22, 2023
@Jarsen136
Copy link
Contributor

may i have any bonus for this pr🤔

if you want to take time, it's oke to fix it in this pr

The compatibility issue should have already been fixed in this PR.

image

@yangwao
Copy link
Member

yangwao commented Aug 23, 2023

pay 30 usd

@yangwao yangwao merged commit 3e8ef7c into kodadot:main Aug 23, 2023
11 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 23, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.42 USD/DOT ~ 6.787 $DOT
🧗 13rv1SWoLg9Gb3tmvHPZxb7JbVy51BtMziX7k9WQGSJ7Kp3A
🔗 0x84da5f0cc87431e32257f23b03ae65a07157a3ac122b2c11095cd7c1d2fa21db

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 23, 2023
This was referenced Aug 23, 2023
Merged
Merged
Merged
Merged
@floyd-li floyd-li deleted the fix/6837 branch October 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@roiLeo roiLeo Awaiting requested review from roiLeo

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer - Info tooltip missing? (NeoTooltip overflow bug on the modal)
8 participants
@floyd-li @kodabot @vikiival @prury @yangwao @Jarsen136 @preschian @exezbcz