Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect templateRef #6854

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix: incorrect templateRef #6854

merged 2 commits into from
Aug 21, 2023

Conversation

stephenjason89
Copy link
Contributor

@stephenjason89 stephenjason89 commented Aug 21, 2023 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 769abca

Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

@stephenjason89 stephenjason89 requested a review from a team as a code owner August 21, 2023 13:05
@stephenjason89 stephenjason89 requested review from roiLeo and vikiival and removed request for a team August 21, 2023 13:05
@kodabot
Copy link
Collaborator

kodabot commented Aug 21, 2023

SUCCESS @stephenjason89 PR for issue #6767 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 21, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8275b6e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e364063a01060008f30117
😎 Deploy Preview https://deploy-preview-6854--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 21, 2023

AI-Generated Summary: This pull request includes a fix for an incorrect ref in the TokenBalanceInput.vue file in the bsx/input component. The ref name is changed from magicBalanceInput to balanceInputComponent. Additionally, a console log statement has been added to the checkValidity() function for debugging purposes, allowing for easier tracking of token balance validity checks.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 21, 2023
roiLeo
roiLeo approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, mint no longer blocked

components/bsx/input/TokenBalanceInput.vue Outdated Show resolved Hide resolved
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 21, 2023
@stephenjason89 @roiLeo
refactor: remove unnecessary console.log
8275b6e 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@codeclimate
Copy link

codeclimate bot commented Aug 21, 2023

Code Climate has analyzed commit 8275b6e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

vikiival
vikiival approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust @roiLeo

@vikiival vikiival merged commit 367c9c7 into kodadot:main Aug 21, 2023
11 checks passed
@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.46 USD/DOT ~ 4.484 $DOT
🧗 16UcV9V6nVvPYdHz98ymUKmNLkzjCEU5sbKJMi7hxYyTHjzR
🔗 0x8afabcc3017c00b6568d8694a79644362c7401c75e239b3170ceaaadf7b96dd7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 21, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Aug 21, 2023

I trust @roiLeo

i-trust-you-kaulder

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 21, 2023
@stephenjason89
Copy link
Contributor Author

I trust @roiLeo

I'll earn your trust, somday😄

This was referenced Aug 21, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@yangwao yangwao mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Listing when creating an NFT on Basilisk won't let you press Create NFT
6 participants
@stephenjason89 @kodabot @vikiival @yangwao @roiLeo @prury