Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loader): Loader won't close when you click outside modal on BSX #6858

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 21, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

Copilot Summary

🤖 Generated by Copilot at 7cacba3

Enabled canceling token creation in CreateToken.vue. This improves the user experience and feedback by giving the user more control and options.

🤖 Generated by Copilot at 7cacba3

can-cancel true
user can stop token creation
a breath of spring air

@hassnian hassnian requested a review from a team as a code owner August 21, 2023 15:10
@hassnian hassnian requested review from preschian and vikiival and removed request for a team August 21, 2023 15:10
@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2b6259b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e37e723cba1f00086ed2bf
😎 Deploy Preview https://deploy-preview-6858--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 21, 2023

AI-Generated Summary: This pull request includes a minor adjustment in the 'CreateToken.vue' component of the 'bsx' module. The change updates the 'Loader' component properties, allowing it to be cancellable, thus enhancing user interaction with the interface. The 'can-cancel' attribute in the 'Loader' component is switched from 'false' to 'can-cancel', indicating that the loader can now be cancelled by the user. The file 'CreateToken.vue' is the only file affected in this patch.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Aug 21, 2023

Code Climate has analyzed commit 2b6259b and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@vikiival vikiival merged commit ea2facc into kodadot:main Aug 21, 2023
11 of 12 checks passed
@vikiival
Copy link
Member

pay 10 usd

1 similar comment
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 4.4 USD/DOT ~ 2.273 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x5805384d33f19391d8d8673ffa3aa43d375dd99974cc7a315ccd1d44f653215c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants