Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateToken to composition API #6896

Merged
merged 7 commits into from
Aug 25, 2023
Merged

CreateToken to composition API #6896

merged 7 commits into from
Aug 25, 2023

Conversation

leo-anderson-x
Copy link
Contributor

@leo-anderson-x leo-anderson-x commented Aug 23, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 2ec3839

Refactor CreateToken component to use Composition API and improve prop naming for clarity.

🤖 Generated by Copilot at 2ec3839

The CreateToken component got a new look
It now uses the Composition API for every hook
The Loader and SubmitButton props were renamed
To avoid confusion and make them more clear
This pull request deserves a thumbs up or a cheer

@netlify
Copy link

netlify bot commented Aug 23, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 70be35f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e5ffd70faeb600083028e1
😎 Deploy Preview https://deploy-preview-6896--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 23, 2023

AI-Generated Summary: This pull request refactors the CreateToken.vue component to use the Vue 3 Composition API. The patch changes 398 lines, with equal numbers of additions and deletions.

Some key changes are:

  • The replacement of class-style components with the use of defineProps which is a part of the new vue3's composition API.
  • The use of ref and watch imported from Vue to track and respond to changes in data properties.
  • The removal of mixins such as authMixin, chainMixin, prefixMixin, and metaMixin, and replacing their functionalities with composable functions, such as useTransactionStatus, useAuth, usePrefix, and useApi.
  • The use of watch to respond to changes in properties. For example, when the accountId value changes, fetchCollections is called to update the state of the application.
  • The use of computed properties to derive state based on other reactive properties.

This change helps improve the readability and maintainability of the code by utilizing Vue 3's advanced reactivity system.

@reviewpad reviewpad bot added the large Pull request is large label Aug 23, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 23, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@leo-anderson-x leo-anderson-x marked this pull request as ready for review August 23, 2023 10:29
@leo-anderson-x leo-anderson-x requested a review from a team as a code owner August 23, 2023 10:29
@leo-anderson-x leo-anderson-x requested review from roiLeo and vikiival and removed request for a team August 23, 2023 10:29
roiLeo
roiLeo reviewed Aug 23, 2023
View reviewed changes
components/bsx/Create/CreateToken.vue Outdated Show resolved Hide resolved
components/bsx/Create/CreateToken.vue Outdated Show resolved Hide resolved
@roiLeo
Copy link
Contributor

roiLeo commented Aug 23, 2023

Tested with /snek/gallery/3124270296-11

@leo-anderson-x @roiLeo
Update components/bsx/Create/CreateToken.vue
1175770 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@vikiival
Copy link
Member

Cc @prury

@leo-anderson-x have you tested that? 🥹

@leo-anderson-x
Copy link
Contributor Author

@leo-anderson-x have you tested that? 🥹

@vikiival I've only tested it briefly on snek and it would be nice to have @prury's verification!

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 70be35f and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@prury
Copy link
Member

prury commented Aug 23, 2023

testing now

@prury
Copy link
Member

prury commented Aug 23, 2023

RMRK1 test:
https://kusama.subscan.io/tx/0x0680cf8826e0bbc283d052d6eaa06bf921c957b3c24cd62359d40c5808ea0aa4 ❌

@roiLeo
Copy link
Contributor

roiLeo commented Aug 23, 2023

RMRK1 test: https://kusama.subscan.io/tx/0x0680cf8826e0bbc283d052d6eaa06bf921c957b3c24cd62359d40c5808ea0aa4 ❌

The changes only impact bsx & snek chain

@prury
Copy link
Member

prury commented Aug 23, 2023

RMRK1 test: https://kusama.subscan.io/tx/0x0680cf8826e0bbc283d052d6eaa06bf921c957b3c24cd62359d40c5808ea0aa4 ❌

The changes only impact bsx & snek chain

my bad, running bsx/snek tests now

@vikiival vikiival mentioned this pull request Aug 23, 2023
Closed
@prury
Copy link
Member

prury commented Aug 23, 2023

ok, it works ✔️
https://deploy-preview-6896--koda-canary.netlify.app/bsx/gallery/5347553-2
https://basilisk.subscan.io/tx/0x0f2e61715b93c2343af5b676315f45bbfa9b6b64df2a149898dc5bfd2ccd6f6a
took a while because i found two unrelated bugs in the process

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 23, 2023
@leo-anderson-x
Copy link
Contributor Author

@vikiival Waiting for your confirmation 😃

@yangwao
Copy link
Member

yangwao commented Aug 25, 2023

pay 70 usd
this one looks big! :)

@yangwao yangwao merged commit 777e640 into kodadot:main Aug 25, 2023
11 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 25, 2023

😍 Perfect, I’ve sent the payout
💵 $70 @ 4.47 USD/DOT ~ 15.66 $DOT
🧗 12RA5J7wGg6bDWPTZG359Pn5bCzXSJRfsifo3UktqVAjhJ9k
🔗 0xe640a2af11b057a60c509a116c2ffe372c4524493377757c4bbdea3259592946

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 25, 2023
@leo-anderson-x leo-anderson-x deleted the 4750-create-token branch August 25, 2023 11:27
This was referenced Aug 25, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
large Pull request is large paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leo-anderson-x @roiLeo @vikiival @prury @yangwao